Thread: [HACKERS] Other formats in pset like markdown, rst, mediawiki

I can try it, doesn`t look dificult, but I`m worry, that I`m not able to write clean, pretty code.

2017-02-23 18:03 GMT+01:00 Alvaro Herrera <alvherre@2ndquadrant.com>:

Leknín Řepánek wrote:
> I was mainly using tables in rst, i think, that this format is very
> similar to "grid tables" in markdown. And it is really similar to default borders used
> in psql with border 2.

Great.  So are you writing the code now?  :-)

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Je;

jelen=# \pset linestyle rst
Line style is rst.
jelen=# \pset format wrapped
Output format is wrapped.
jelen=# SELECT repeat('Goodnight Irene ', 30);
+-----------------------------------------------------------------------------+
|                                   repeat                                    |
+=============================================================================+
| Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight I.|
|.rene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodni.|
|.ght Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene G.|
|.oodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Ir.|
|.ene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnig.|
|.ht Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Go.|
|.odnight Irene Goodnight Irene                                               |
+-----------------------------------------------------------------------------+

(1 row)

jelen=#

2017-03-01 15:00 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

If you want to implement a new table format, you should be looking at
\pset format, not \pset linestyle.  \pset format sets different table
formats, such as html, latex, and asciidoc.  \pset linestyle just
chooses between different styles for the plain-text table format.

On 3/1/17 06:31, Jan Michálek wrote:
> Regression test corrected.
>
> 2017-03-01 11:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
> <mailto:godzilalalala@gmail.com>>:
>
>     Sorry, I have some errors in my diff, i had copy something from bad
>     folder. I will fix it.
>
>     2017-03-01 0:27 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
>     <mailto:godzilalalala@gmail.com>>:
>
>         There it is, what i have.
>         I need i small help with psql.out, because \pset format wrapped.
>         I don`t know, how to have it in fixed width.
>
>         2017-02-28 14:23 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
>         <mailto:godzilalalala@gmail.com>>:

>
>             Current state is something like this (diff is attached).
>             I currently haven`t regression test, tab completion etc., I
>             will add this thing following structure of asciidoc commit.
>
>             Output is tested using retext, rst is OK, md have problem
>             with cells with newline (i must find out, how it is possible
>             create table with this in markdown).
>
>             [jelen@laptak patch_postgre_rst]$
>             [jelen@laptak psql]$ ./psql
>             psql (9.6.2, server 9.6.1)
>             Type "help" for help.
>
>             jelen=# \pset linestyle markdown
>             Line style is markdown.
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g | xclip
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g
>
>             |    column1    |     column2      |
>             |---------------|------------------|
>             | nasral Franta | Žluťoučký kobyly |
>             | na trabanta   |                  |
>             | '             | a       b        |
>
>
>             (2 rows)
>
>             jelen=# \pset linestyle rst
>             Line style is rst.
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g
>             +---------------+------------------+
>             |    column1    |     column2      |
>             +===============+==================+
>             | nasral Franta+| Žluťoučký kobyly |
>             | na trabanta   |                  |
>             +---------------+------------------+
>             | '             | a       b        |
>             +---------------+------------------+
>
>             (2 rows)
>
>             jelen=#
>
>             2017-02-24 0:46 GMT+01:00 Michael Paquier

>             <michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>>:
>
>                 On Fri, Feb 24, 2017 at 3:09 AM, Jan Michálek
>                 <godzilalalala@gmail.com

>                 <mailto:godzilalalala@gmail.com>> wrote:
>                 > I can try it, doesn`t look dificult, but I`m worry, that I`m not able to
>                 > write clean, pretty code.
>
>                 If you want to have something available in Postgres 10,
>                 you had better
>                 be quick. The last commit fest of the development cycle
>                 of Postgres 10
>                 begins on the 1st of March, you need to to register your
>                 patch here:
>                 https://commitfest.postgresql.org/13/
>                 <https://commitfest.postgresql.org/13/>
>                 Here are also some rough guidelines about submitting a
>                 patch:
>                 https://wiki.postgresql.org/wiki/Submitting_a_Patch
>                 <https://wiki.postgresql.org/wiki/Submitting_a_Patch>
>                 --
>                 Michael
>
>
>
>
>             --
>             Jelen
>             Starší čeledín datovýho chlíva
>
>
>
>
>         --
>         Jelen
>         Starší čeledín datovýho chlíva
>
>
>
>
>     --
>     Jelen
>     Starší čeledín datovýho chlíva
>
>
>
>
> --
> Jelen
> Starší čeledín datovýho chlíva
>
>
>

--
Peter Eisentraut              http://www.2ndQuadrant.com/

PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines.

2017-03-05 12:36 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 11:40 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Using a special linestyle for new format is possible probably. But new format should be switched with \pset format command.

Not sure if wrapped or aligned behave is correct for markdown - it is task for markdown processing, not for psql.

Regards

Pavel

 

Je;

jelen=# \pset linestyle rst
Line style is rst.
jelen=# \pset format wrapped
Output format is wrapped.
jelen=# SELECT repeat('Goodnight Irene ', 30);
+-----------------------------------------------------------------------------+
|                                   repeat                                    |
+=============================================================================+
| Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight I.|
|.rene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodni.|
|.ght Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene G.|
|.oodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Ir.|
|.ene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnig.|
|.ht Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene Go.|
|.odnight Irene Goodnight Irene                                               |
+-----------------------------------------------------------------------------+

(1 row)

jelen=#

2017-03-01 15:00 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

If you want to implement a new table format, you should be looking at
\pset format, not \pset linestyle.  \pset format sets different table
formats, such as html, latex, and asciidoc.  \pset linestyle just
chooses between different styles for the plain-text table format.

On 3/1/17 06:31, Jan Michálek wrote:
> Regression test corrected.
>
> 2017-03-01 11:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
> <mailto:godzilalalala@gmail.com>>:
>
>     Sorry, I have some errors in my diff, i had copy something from bad
>     folder. I will fix it.
>
>     2017-03-01 0:27 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
>     <mailto:godzilalalala@gmail.com>>:
>
>         There it is, what i have.
>         I need i small help with psql.out, because \pset format wrapped.
>         I don`t know, how to have it in fixed width.
>
>         2017-02-28 14:23 GMT+01:00 Jan Michálek <godzilalalala@gmail.com
>         <mailto:godzilalalala@gmail.com>>:

>
>             Current state is something like this (diff is attached).
>             I currently haven`t regression test, tab completion etc., I
>             will add this thing following structure of asciidoc commit.
>
>             Output is tested using retext, rst is OK, md have problem
>             with cells with newline (i must find out, how it is possible
>             create table with this in markdown).
>
>             [jelen@laptak patch_postgre_rst]$
>             [jelen@laptak psql]$ ./psql
>             psql (9.6.2, server 9.6.1)
>             Type "help" for help.
>
>             jelen=# \pset linestyle markdown
>             Line style is markdown.
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g | xclip
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g
>
>             |    column1    |     column2      |
>             |---------------|------------------|
>             | nasral Franta | Žluťoučký kobyly |
>             | na trabanta   |                  |
>             | '             | a       b        |
>
>
>             (2 rows)
>
>             jelen=# \pset linestyle rst
>             Line style is rst.
>             jelen=# values(E'nasral Franta\nna trabanta','Žluťoučký
>             kobyly'), ('''',E'a\tb') \g
>             +---------------+------------------+
>             |    column1    |     column2      |
>             +===============+==================+
>             | nasral Franta+| Žluťoučký kobyly |
>             | na trabanta   |                  |
>             +---------------+------------------+
>             | '             | a       b        |
>             +---------------+------------------+
>
>             (2 rows)
>
>             jelen=#
>
>             2017-02-24 0:46 GMT+01:00 Michael Paquier

>             <michael.paquier@gmail.com <mailto:michael.paquier@gmail.com>>:
>
>                 On Fri, Feb 24, 2017 at 3:09 AM, Jan Michálek
>                 <godzilalalala@gmail.com

>                 <mailto:godzilalalala@gmail.com>> wrote:
>                 > I can try it, doesn`t look dificult, but I`m worry, that I`m not able to
>                 > write clean, pretty code.
>
>                 If you want to have something available in Postgres 10,
>                 you had better
>                 be quick. The last commit fest of the development cycle
>                 of Postgres 10
>                 begins on the 1st of March, you need to to register your
>                 patch here:
>                 https://commitfest.postgresql.org/13/
>                 <https://commitfest.postgresql.org/13/>
>                 Here are also some rough guidelines about submitting a
>                 patch:
>                 https://wiki.postgresql.org/wiki/Submitting_a_Patch
>                 <https://wiki.postgresql.org/wiki/Submitting_a_Patch>
>                 --
>                 Michael
>
>
>
>
>             --
>             Jelen
>             Starší čeledín datovýho chlíva
>
>
>
>
>         --
>         Jelen
>         Starší čeledín datovýho chlíva
>
>
>
>
>     --
>     Jelen
>     Starší čeledín datovýho chlíva
>
>
>
>
> --
> Jelen
> Starší čeledín datovýho chlíva
>
>
>

--
Peter Eisentraut              http://www.2ndQuadrant.com/

PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

2017-03-05 13:08 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines.

Please, don't do top posting https://en.wikipedia.org/wiki/Posting_style#Top-posting

2017-03-05 12:36 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 11:40 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Using a special linestyle for new format is possible probably. But new format should be switched with \pset format command.

Not sure if wrapped or aligned behave is correct for markdown - it is task for markdown processing, not for psql.

In this case I am inclined to prefer setting via format setting - you can set a linestyle and border in one step, and then is easy to return back to previous format. I don't see a big benefit in enhancing set of ascii linestyles. The collecting new features in formatting is more intuitive (for me).

| Tables        | Are           | Cool  |
| ------------- |:-------------:| -----:|
| col 3 is      | right-aligned | $1600 |
| col 2 is      | centered      |   $12 |
| zebra stripes | are neat      |    $1 |

2017-03-05 13:22 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 13:08 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines.

Please, don't do top posting https://en.wikipedia.org/wiki/Posting_style#Top-posting

2017-03-05 12:36 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 11:40 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Using a special linestyle for new format is possible probably. But new format should be switched with \pset format command.

Not sure if wrapped or aligned behave is correct for markdown - it is task for markdown processing, not for psql.

In this case I am inclined to prefer setting via format setting - you can set a linestyle and border in one step, and then is easy to return back to previous format. I don't see a big benefit in enhancing set of ascii linestyles. The collecting new features in formatting is more intuitive (for me).

 This can be discussed what we prefer, and what we would to implement?

1. Nice formatted markdown tables

| Tables        | Are           | Cool  |
| ------------- |:-------------:| -----:|
| col 3 is      | right-aligned | $1600 |
| col 2 is      | centered      |   $12 |
| zebra stripes | are neat      |    $1 |

or 2. enough formatting

Markdown | Less | Pretty
--- | --- | ---
*Still* | `renders` | **nicely**
1 | 2 | 3

Pavel

2017-03-05 13:39 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 13:22 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 13:08 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines.

Please, don't do top posting https://en.wikipedia.org/wiki/Posting_style#Top-posting

2017-03-05 12:36 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 11:40 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Using a special linestyle for new format is possible probably. But new format should be switched with \pset format command.

Not sure if wrapped or aligned behave is correct for markdown - it is task for markdown processing, not for psql.

In this case I am inclined to prefer setting via format setting - you can set a linestyle and border in one step, and then is easy to return back to previous format. I don't see a big benefit in enhancing set of ascii linestyles. The collecting new features in formatting is more intuitive (for me).

 This can be discussed what we prefer, and what we would to implement?

1. Nice formatted markdown tables

| Tables        | Are           | Cool  |
| ------------- |:-------------:| -----:|
| col 3 is      | right-aligned | $1600 |
| col 2 is      | centered      |   $12 |
| zebra stripes | are neat      |    $1 |

or 2. enough formatting

Markdown | Less | Pretty
--- | --- | ---
*Still* | `renders` | **nicely**
1 | 2 | 3

I personally prefer nice formated table, because more comfortable reading source of document and easier editing with blocks (deleting whole columns etc.).

I will change \pset to format.

I find, when adding <\br> for newline works in retext. I will try to add it to patch.

| Tables | Are | Cool |

| ------------- |:-------------:| -----:|

| col 3 is | right-aligned | $1600 |

| col 2 is | centere<br/>d | $12 |

| zebra stripes | are neat | $1 |

Jan

 

Pavel

--

Jelen

Starší čeledín datovýho chlíva

2017-03-06 16:17 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-06 15:19 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-06 0:26 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-05 14:02 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-05 13:39 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 13:22 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 13:08 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

It is question if it is really new format, because formating is the same as aligned/wrapped format, changed is only style of lines.

Please, don't do top posting https://en.wikipedia.org/wiki/Posting_style#Top-posting

2017-03-05 12:36 GMT+01:00 Pavel Stehule <pavel.stehule@gmail.com>:

2017-03-05 11:40 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

I know, but, both new linestyles are created literally by cloning ascii linestyle and few lines in print_aligned_text. Both works with "aligned" and "wrapped" format. In rst is wrapped format useful, in my opinion, in markdown i can`t find how I can get newline in record (maybe it is not posiible in main markdown types). So it is why i add markdown and rst as new linestyles. But it is not problem to change it in command to use "\pset format", but i mean, that this is cleaner.

Using a special linestyle for new format is possible probably. But new format should be switched with \pset format command.

changed

quick test shows it is working.

Just idea - can you specify aligning? right aligning for numbers, left for others?

I used "aligned" format as it is and I don`t know, if I`m able to do this with current solution based only on change linestyle internally.

you can try to test result in some markdown processors? I will not be surprised if these processor ignore aligning in input data.

Refards

Pavel

 

Regards

Pavel

--

Jelen

Starší čeledín datovýho chlíva

On 3/5/17 05:40, Jan Michálek wrote:
> jelen=# \pset linestyle rst
> Line style is rst.
> jelen=# \pset format wrapped
> Output format is wrapped.
> jelen=# SELECT repeat('Goodnight Irene ', 30);
> +-----------------------------------------------------------------------------+
> |
> repeat                                    |
> +=============================================================================+
> | Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene
> Goodnight I.|
> |.rene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight Irene
> Goodni.|
> |.ght Irene Goodnight Irene Goodnight Irene Goodnight Irene Goodnight
> Irene G.|

I doubt that this kind of line breaking style is actually proper rst.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

- Does not support \x

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

- Broken output in tuples_only (\t) mode. (rst and markdown)

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

- markdown: Extra blank line between table and footer.

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

- markdown: Table title needs to be after the table, like

    Table: title

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

I prepared something like this (i have no prepared diff, i need do some another changes)

There a few things I need to do. First problem is bold column names, i should do it in sme fashin as "RECORD", but i need to do some research about length of column.

Bigger problem is with tab indent, rst processor doesn`t work with this in this case.

 

jelen=# execute q \g | xclip
+---------+------------------------------------------------------------------------+
| **RECORD 1**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | Elephant, kangaroo,                                                    |
|         | squirrel, gorilla                                                      |
+---------+------------------------------------------------------------------------+
| column2 | 121                                                                    |
+---------+------------------------------------------------------------------------+
| column3 | 1.0035971223021583                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 0.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello Hello            |
+---------+------------------------------------------------------------------------+
| **RECORD 2**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | goat, rhinoceros,                                                      |
|         | monkey, ape                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 11121                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 1.0007824726134585                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 5.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx  |
+---------+------------------------------------------------------------------------+
| **RECORD 3**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | donkey, cow, horse, tit,                                               |
|         | eagle, whale,                                                          |
|         | aligator,                                                              |
|         |    pelican,                                                            |
|         | grasshoper                                                             |
|         | pig                                                                    |
|         |         bat                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 14351                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 50.3877551020408163                                                    |
+---------+------------------------------------------------------------------------+
| column4 | 345.11                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy  |
+---------+------------------------------------------------------------------------+



 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

Hi,

I like your suggestion and took a look at your patch though I’m not the expert about psql.

 

I like the idea taking advantage of linestyle utilities 

to implement rst and markdown format efficiently instead of newly developing pset format things.

But I'm thinking two comments below needs change to something about not focusing only linestyle.

That's because they really take care of both '\pset linestyle and \pset format' and it may lead to misunderstanding to readers.

 

---

/* Line style control structures */

const printTextFormat pg_markdown =

 

/* get selected or default line style */

const printTextFormat *

get_line_style(const printTableOpt *opt)

---

 

The rest things are about code style convention.

- there are some indents with white spaces around skip_leading_spaces_print()

  but Postgresql conventions says indents should be with 4 column tab.

  https://www.postgresql.org/docs/devel/static/source-format.html

 

- On the other hand, in docs there are some tab indent

  but white space indenet is preferable. Looking around sgml files, white space is used.

 

- some multi-line comment style also needs fix according to the above documentation (link)

 

- And I also found patch cannot be applied to current master.

 

Regards,

Ideriha, Takeshi

 

From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Jan Michalek
Sent: Sunday, March 19, 2017 5:10 AM
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>; PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

 

 

 

2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

 

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

 

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

I prepared something like this (i have no prepared diff, i need do some another changes)

There a few things I need to do. First problem is bold column names, i should do it in sme fashin as "RECORD", but i need to do some research about length of column.

Bigger problem is with tab indent, rst processor doesn`t work with this in this case.

In new diff is added \x for rst and skipping leading spaces in rst in both. make check passed

 

Jan

 

 

jelen=# execute q \g | xclip
+---------+------------------------------------------------------------------------+
| **RECORD 1**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | Elephant, kangaroo,                                                    |
|         | squirrel, gorilla                                                      |
+---------+------------------------------------------------------------------------+
| column2 | 121                                                                    |
+---------+------------------------------------------------------------------------+
| column3 | 1.0035971223021583                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 0.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello Hello            |
+---------+------------------------------------------------------------------------+
| **RECORD 2**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | goat, rhinoceros,                                                      |
|         | monkey, ape                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 11121                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 1.0007824726134585                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 5.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx  |
+---------+------------------------------------------------------------------------+
| **RECORD 3**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | donkey, cow, horse, tit,                                               |
|         | eagle, whale,                                                          |
|         | aligator,                                                              |
|         |    pelican,                                                            |
|         | grasshoper                                                             |
|         | pig                                                                    |
|         |         bat                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 14351                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 50.3877551020408163                                                    |
+---------+------------------------------------------------------------------------+
| column4 | 345.11                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy  |
+---------+------------------------------------------------------------------------+



 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

 

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

 

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

 

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

 

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

 

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

 

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

 

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

Hi,

I like your suggestion and took a look at your patch though I’m not the expert about psql.

 

I like the idea taking advantage of linestyle utilities

to implement rst and markdown format efficiently instead of newly developing pset format things.

But I'm thinking two comments below needs change to something about not focusing only linestyle.

That's because they really take care of both '\pset linestyle and \pset format' and it may lead to misunderstanding to readers.

 

---

/* Line style control structures */

const printTextFormat pg_markdown =

 

/* get selected or default line style */

const printTextFormat *

get_line_style(const printTableOpt *opt)

---

 

The rest things are about code style convention.

- there are some indents with white spaces around skip_leading_spaces_print()

  but Postgresql conventions says indents should be with 4 column tab.

  https://www.postgresql.org/docs/devel/static/source-format.html

 

- On the other hand, in docs there are some tab indent

  but white space indenet is preferable. Looking around sgml files, white space is used.

 

- some multi-line comment style also needs fix according to the above documentation (link)

 

- And I also found patch cannot be applied to current master.

 

Regards,

Ideriha, Takeshi

 

From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Jan Michalek
Sent: Sunday, March 19, 2017 5:10 AM
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>; PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

 

 

 

2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

 

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

 

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

I prepared something like this (i have no prepared diff, i need do some another changes)

There a few things I need to do. First problem is bold column names, i should do it in sme fashin as "RECORD", but i need to do some research about length of column.

Bigger problem is with tab indent, rst processor doesn`t work with this in this case.

In new diff is added \x for rst and skipping leading spaces in rst in both. make check passed

 

Jan

 

 

jelen=# execute q \g | xclip
+---------+------------------------------------------------------------------------+
| **RECORD 1**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | Elephant, kangaroo,                                                    |
|         | squirrel, gorilla                                                      |
+---------+------------------------------------------------------------------------+
| column2 | 121                                                                    |
+---------+------------------------------------------------------------------------+
| column3 | 1.0035971223021583                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 0.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello Hello            |
+---------+------------------------------------------------------------------------+
| **RECORD 2**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | goat, rhinoceros,                                                      |
|         | monkey, ape                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 11121                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 1.0007824726134585                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 5.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx  |
+---------+------------------------------------------------------------------------+
| **RECORD 3**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | donkey, cow, horse, tit,                                               |
|         | eagle, whale,                                                          |
|         | aligator,                                                              |
|         |    pelican,                                                            |
|         | grasshoper                                                             |
|         | pig                                                                    |
|         |         bat                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 14351                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 50.3877551020408163                                                    |
+---------+------------------------------------------------------------------------+
| column4 | 345.11                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy  |
+---------+------------------------------------------------------------------------+



 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

 

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

 

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

 

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

 

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

 

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

 

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

 

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

2017-03-21 9:59 GMT+01:00 Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>:

Hi,

I like your suggestion and took a look at your patch though I’m not the expert about psql.

 

I like the idea taking advantage of linestyle utilities

to implement rst and markdown format efficiently instead of newly developing pset format things.

But I'm thinking two comments below needs change to something about not focusing only linestyle.

That's because they really take care of both '\pset linestyle and \pset format' and it may lead to misunderstanding to readers.

 

---

/* Line style control structures */

const printTextFormat pg_markdown =

 

/* get selected or default line style */

const printTextFormat *

get_line_style(const printTableOpt *opt)

---

It is in command.c?

I have it done that \pset format changes linestyle

psql (9.6.2, server 9.6.1)
Type "help" for help.

jelen=# \pset linestyle ascii
Line style is ascii.
jelen=# \pset format rst
Output format is rst.
jelen=# \pset linestyle
Line style is rst.
jelen=#

Peter wrote that this is not right, but i don`t know how it should like, because most of this is done on linestyle, format is used only for switch from console.

 

 

The rest things are about code style convention.

- there are some indents with white spaces around skip_leading_spaces_print()

  but Postgresql conventions says indents should be with 4 column tab.

  https://www.postgresql.org/docs/devel/static/source-format.html

Thanks, i often using 4 whitespaces (i have it in vim) but in other code i found mostly used 8 whitespaces.

I will look on this. I use code from another functions (fputnbytes, print_html_escaped) as template.

 

 

- On the other hand, in docs there are some tab indent

  but white space indenet is preferable. Looking around sgml files, white space is used.

 

- some multi-line comment style also needs fix according to the above documentation (link)

I will look on the comments, this is only work version, coding style issues will be corrected (i have some comments only my orientation in code).

 

 

- And I also found patch cannot be applied to current master.

I have 9.6.2 source code. It is not correct? Where i find source code i should use?

Have nice day
Jan

 

 

Regards,

Ideriha, Takeshi

 

From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Jan Michalek
Sent: Sunday, March 19, 2017 5:10 AM
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>; PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

 

 

 

2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

 

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

 

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

I prepared something like this (i have no prepared diff, i need do some another changes)

There a few things I need to do. First problem is bold column names, i should do it in sme fashin as "RECORD", but i need to do some research about length of column.

Bigger problem is with tab indent, rst processor doesn`t work with this in this case.

In new diff is added \x for rst and skipping leading spaces in rst in both. make check passed

 

Jan

 

 

jelen=# execute q \g | xclip
+---------+------------------------------------------------------------------------+
| **RECORD 1**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | Elephant, kangaroo,                                                    |
|         | squirrel, gorilla                                                      |
+---------+------------------------------------------------------------------------+
| column2 | 121                                                                    |
+---------+------------------------------------------------------------------------+
| column3 | 1.0035971223021583                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 0.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello Hello            |
+---------+------------------------------------------------------------------------+
| **RECORD 2**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | goat, rhinoceros,                                                      |
|         | monkey, ape                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 11121                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 1.0007824726134585                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 5.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx  |
+---------+------------------------------------------------------------------------+
| **RECORD 3**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | donkey, cow, horse, tit,                                               |
|         | eagle, whale,                                                          |
|         | aligator,                                                              |
|         |    pelican,                                                            |
|         | grasshoper                                                             |
|         | pig                                                                    |
|         |         bat                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 14351                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 50.3877551020408163                                                    |
+---------+------------------------------------------------------------------------+
| column4 | 345.11                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy  |
+---------+------------------------------------------------------------------------+



 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

 

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

 

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

 

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

 

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

 

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

 

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

 

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

2017-03-21 10:59 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-21 9:59 GMT+01:00 Ideriha, Takeshi <ideriha.takeshi@jp.fujitsu.com>:

Hi,

I like your suggestion and took a look at your patch though I’m not the expert about psql.

 

I like the idea taking advantage of linestyle utilities

to implement rst and markdown format efficiently instead of newly developing pset format things.

But I'm thinking two comments below needs change to something about not focusing only linestyle.

That's because they really take care of both '\pset linestyle and \pset format' and it may lead to misunderstanding to readers.

 

---

/* Line style control structures */

const printTextFormat pg_markdown =

 

/* get selected or default line style */

const printTextFormat *

get_line_style(const printTableOpt *opt)

---

It is in command.c?

I have it done that \pset format changes linestyle

psql (9.6.2, server 9.6.1)
Type "help" for help.

jelen=# \pset linestyle ascii
Line style is ascii.
jelen=# \pset format rst
Output format is rst.
jelen=# \pset linestyle
Line style is rst.
jelen=#

Peter wrote that this is not right, but i don`t know how it should like, because most of this is done on linestyle, format is used only for switch from console.

 

 

The rest things are about code style convention.

- there are some indents with white spaces around skip_leading_spaces_print()

  but Postgresql conventions says indents should be with 4 column tab.

  https://www.postgresql.org/docs/devel/static/source-format.html

Thanks, i often using 4 whitespaces (i have it in vim) but in other code i found mostly used 8 whitespaces.

I will look on this. I use code from another functions (fputnbytes, print_html_escaped) as template.

 

 

- On the other hand, in docs there are some tab indent

  but white space indenet is preferable. Looking around sgml files, white space is used.

 

- some multi-line comment style also needs fix according to the above documentation (link)

I will look on the comments, this is only work version, coding style issues will be corrected (i have some comments only my orientation in code).

 

 

- And I also found patch cannot be applied to current master.

I have 9.6.2 source code. It is not correct? Where i find source code i should use?

Please use git  master  https://wiki.postgresql.org/wiki/Working_with_Git

Regards

Pavel

Have nice day
Jan

 

 

Regards,

Ideriha, Takeshi

 

From: pgsql-hackers-owner@postgresql.org [mailto:pgsql-hackers-owner@postgresql.org] On Behalf Of Jan Michalek
Sent: Sunday, March 19, 2017 5:10 AM
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>; PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] Other formats in pset like markdown, rst, mediawiki

 

 

 

2017-03-12 19:21 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-10 9:43 GMT+01:00 Jan Michálek <godzilalalala@gmail.com>:

 

 

2017-03-09 20:10 GMT+01:00 Peter Eisentraut <peter.eisentraut@2ndquadrant.com>:

This is looking pretty neat.  I played around with it a bit.  There are
a couple of edge cases that you need to address, I think.

 

Thanks, original code is very synoptical and and well prepared for adding new formats.

 

- Does not support \x

 

I know, i dnot`t know, if \x make sense in this case. I will look, how it is done in other formats like html. I think, that it should work in sense, that table generated to rst should give similar output after processing like output of html format.

 

I prepared something like this (i have no prepared diff, i need do some another changes)

There a few things I need to do. First problem is bold column names, i should do it in sme fashin as "RECORD", but i need to do some research about length of column.

Bigger problem is with tab indent, rst processor doesn`t work with this in this case.

In new diff is added \x for rst and skipping leading spaces in rst in both. make check passed

 

Jan

 

 

jelen=# execute q \g | xclip
+---------+------------------------------------------------------------------------+
| **RECORD 1**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | Elephant, kangaroo,                                                    |
|         | squirrel, gorilla                                                      |
+---------+------------------------------------------------------------------------+
| column2 | 121                                                                    |
+---------+------------------------------------------------------------------------+
| column3 | 1.0035971223021583                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 0.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | Hello Hello Hello Hello Hello Hello Hello Hello Hello Hello            |
+---------+------------------------------------------------------------------------+
| **RECORD 2**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | goat, rhinoceros,                                                      |
|         | monkey, ape                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 11121                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 1.0007824726134585                                                     |
+---------+------------------------------------------------------------------------+
| column4 | 5.1111                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx xxxxxx  |
+---------+------------------------------------------------------------------------+
| **RECORD 3**                                                                     |
+---------+------------------------------------------------------------------------+
| column1 | donkey, cow, horse, tit,                                               |
|         | eagle, whale,                                                          |
|         | aligator,                                                              |
|         |    pelican,                                                            |
|         | grasshoper                                                             |
|         | pig                                                                    |
|         |         bat                                                            |
+---------+------------------------------------------------------------------------+
| column2 | 14351                                                                  |
+---------+------------------------------------------------------------------------+
| column3 | 50.3877551020408163                                                    |
+---------+------------------------------------------------------------------------+
| column4 | 345.11                                                                 |
+---------+------------------------------------------------------------------------+
| column5 | yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy yyyyyy  |
+---------+------------------------------------------------------------------------+



 

- When \pset format is rst, then \pset linestyle also shows up as
  "rst".  That is wrong.  Same for markdown.

 

I will look on this.

 

- Broken output in tuples_only (\t) mode. (rst and markdown)

 

Similar to \x, im not certain, what it should return. I will look, what returns html format. Or i can use it in markdown for nice vs expanded format.

 

- rst: Do something about \pset title; the way it currently shows up
  appears to be invalid; could use ".. table:: title" directive

 

OK, it shouldn`t be problem alter this.

 

- markdown: Extra blank line between table and footer.

 

It is because markdown needs empty line after table, if is row count presented.

 

- markdown: We should document or comment somewhere exactly which of the
  various markdown table formats this is supposed to produce.  (Pandoc
  pipe_tables?)

 

I use format that was similar to aligned format and ascii linestyle, because it allows me to use existing features. I should look over more table styles in markdown.

 

- markdown: Table title needs to be after the table, like

    Table: title

I will change this.

 

- markdown: Needs to escape | characters in cell contents.  (Not
  needed for rst.)  More escaping might be needed.

 

This can be problem because of aligning, i will look on this, this same problem as replace newline with </br> for markdown.

 

Have Nice day

Jan

 

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi

This is my first review (Magnus said in his presentation in PGDay Paris that volunteers should just come and help, so here I am), so please notify me for any mistake I do when using the review tools...

The feature seems to work as expected, but I don't claim to be a markdown and rst expert.
Some minor issues with the code itself :
- some indentation issues (documentation and code itself with mix between space based and tab based indentation) and a few trailing spaces in code
- typographic issues in the documentation :
  - "The html, asciidoc, latex, latex-longtable, troff-ms, and markdown and rst formats" ==> duplicated and
  - "Sets the output format to one of unaligned, aligned, wrapped, html, asciidoc, latex (uses tabular), latex-longtable, rst, markdown, or troff-ms." ==> extra comma at the end of the list
- the comment " dont add line after last row, because line is added after every row" is misleading, it should warn that it's only for rst
- there is a block of commented out code left
- in the print_aligned_vertical function, there is a mix between "cont->opt->format == PRINT_RST" and "format == &pg_rst" and I don't see any obvious reason for that
- the documentation doesn't mention (but ok, it's kind of obvious) that the linestyle option will not work with rst and markdown

Thanks !

The new status of this patch is: Waiting on Author

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi

This is my first review (Magnus said in his presentation in PGDay Paris that volunteers should just come and help, so here I am), so please notify me for any mistake I do when using the review tools...

The feature seems to work as expected, but I don't claim to be a markdown and rst expert.
Some minor issues with the code itself :
- some indentation issues (documentation and code itself with mix between space based and tab based indentation) and a few trailing spaces in code

- typographic issues in the documentation :
  - "The html, asciidoc, latex, latex-longtable, troff-ms, and markdown and rst formats" ==> duplicated and

  - "Sets the output format to one of unaligned, aligned, wrapped, html, asciidoc, latex (uses tabular), latex-longtable, rst, markdown, or troff-ms." ==> extra comma at the end of the list
- the comment " dont add line after last row, because line is added after every row" is misleading, it should warn that it's only for rst
- there is a block of commented out code left
- in the print_aligned_vertical function, there is a mix between "cont->opt->format == PRINT_RST" and "format == &pg_rst" and I don't see any obvious reason for that

- the documentation doesn't mention (but ok, it's kind of obvious) that the linestyle option will not work with rst and markdown

Thanks !

The new status of this patch is: Waiting on Author

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

2017-03-23 17:26 GMT+01:00 Pierre Ducroquet <p.psql@pinaraf.info>:

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi

This is my first review (Magnus said in his presentation in PGDay Paris that volunteers should just come and help, so here I am), so please notify me for any mistake I do when using the review tools...

The feature seems to work as expected, but I don't claim to be a markdown and rst expert.
Some minor issues with the code itself :
- some indentation issues (documentation and code itself with mix between space based and tab based indentation) and a few trailing spaces in code

corrected

 

- typographic issues in the documentation :
  - "The html, asciidoc, latex, latex-longtable, troff-ms, and markdown and rst formats" ==> duplicated and

corrected

  - "Sets the output format to one of unaligned, aligned, wrapped, html, asciidoc, latex (uses tabular), latex-longtable, rst, markdown, or troff-ms." ==> extra comma at the end of the list
- the comment " dont add line after last row, because line is added after every row" is misleading, it should warn that it's only for rst
- there is a block of commented out code left
- in the print_aligned_vertical function, there is a mix between "cont->opt->format == PRINT_RST" and "format == &pg_rst" and I don't see any obvious reason for that

corrected

- the documentation doesn't mention (but ok, it's kind of obvious) that the linestyle option will not work with rst and markdown

In this patch are corrected (i hope, i had correct changes in vimrc) indentation issues. Plese, look at this if it is OK (i men indentats) and some minor errors. And it should work on current master (probably).

Have nice day

Jan

 

Thanks !

The new status of this patch is: Waiting on Author

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--

Jelen

Starší čeledín datovýho chlíva

2017-03-27 19:41 GMT+02:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-23 17:26 GMT+01:00 Pierre Ducroquet <p.psql@pinaraf.info>:

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi

This is my first review (Magnus said in his presentation in PGDay Paris that volunteers should just come and help, so here I am), so please notify me for any mistake I do when using the review tools...

The feature seems to work as expected, but I don't claim to be a markdown and rst expert.
Some minor issues with the code itself :
- some indentation issues (documentation and code itself with mix between space based and tab based indentation) and a few trailing spaces in code

corrected

 

- typographic issues in the documentation :
  - "The html, asciidoc, latex, latex-longtable, troff-ms, and markdown and rst formats" ==> duplicated and

corrected

  - "Sets the output format to one of unaligned, aligned, wrapped, html, asciidoc, latex (uses tabular), latex-longtable, rst, markdown, or troff-ms." ==> extra comma at the end of the list
- the comment " dont add line after last row, because line is added after every row" is misleading, it should warn that it's only for rst
- there is a block of commented out code left
- in the print_aligned_vertical function, there is a mix between "cont->opt->format == PRINT_RST" and "format == &pg_rst" and I don't see any obvious reason for that

corrected

- the documentation doesn't mention (but ok, it's kind of obvious) that the linestyle option will not work with rst and markdown

In this patch are corrected (i hope, i had correct changes in vimrc) indentation issues. Plese, look at this if it is OK (i men indentats) and some minor errors. And it should work on current master (probably).

Added \x option form markdown

In markdown works multiline cels (newline replaced by </br>)

regre tests passed

Jan

 

Have nice day

Jan

 

Thanks !

The new status of this patch is: Waiting on Author

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

2017-03-29 20:11 GMT+02:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-27 19:41 GMT+02:00 Jan Michálek <godzilalalala@gmail.com>:

2017-03-23 17:26 GMT+01:00 Pierre Ducroquet <p.psql@pinaraf.info>:

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           tested, passed
Documentation:            tested, passed

Hi

This is my first review (Magnus said in his presentation in PGDay Paris that volunteers should just come and help, so here I am), so please notify me for any mistake I do when using the review tools...

The feature seems to work as expected, but I don't claim to be a markdown and rst expert.
Some minor issues with the code itself :
- some indentation issues (documentation and code itself with mix between space based and tab based indentation) and a few trailing spaces in code

corrected

 

- typographic issues in the documentation :
  - "The html, asciidoc, latex, latex-longtable, troff-ms, and markdown and rst formats" ==> duplicated and

corrected

  - "Sets the output format to one of unaligned, aligned, wrapped, html, asciidoc, latex (uses tabular), latex-longtable, rst, markdown, or troff-ms." ==> extra comma at the end of the list
- the comment " dont add line after last row, because line is added after every row" is misleading, it should warn that it's only for rst
- there is a block of commented out code left
- in the print_aligned_vertical function, there is a mix between "cont->opt->format == PRINT_RST" and "format == &pg_rst" and I don't see any obvious reason for that

corrected

- the documentation doesn't mention (but ok, it's kind of obvious) that the linestyle option will not work with rst and markdown

In this patch are corrected (i hope, i had correct changes in vimrc) indentation issues. Plese, look at this if it is OK (i men indentats) and some minor errors. And it should work on current master (probably).

Added \x option form markdown

In markdown works multiline cels (newline replaced by </br>)

regre tests passed

\pset format rst

\x

select 10

crash on segfault

Program received signal SIGSEGV, Segmentation fault.

0x00007f77673a866c in vfprintf () from /lib64/libc.so.6

(gdb) bt

#0  0x00007f77673a866c in vfprintf () from /lib64/libc.so.6

#1  0x00007f77673b1574 in fprintf () from /lib64/libc.so.6

#2  0x0000000000437bc5 in print_aligned_vertical (cont=0x7fffade43da0, fout=<optimized out>, 

    is_pager=<optimized out>) at print.c:1755

#3  0x000000000043a70d in printTable (cont=cont@entry=0x7fffade43da0, fout=<optimized out>, 

    fout@entry=0x7f77677255e0 <_IO_2_1_stdout_>, is_pager=<optimized out>, is_pager@entry=0 '\000', 

    flog=flog@entry=0x0) at print.c:3466

#4  0x000000000043c37f in printQuery (result=result@entry=0x9c4b60, opt=opt@entry=0x7fffade43f00, 

    fout=0x7f77677255e0 <_IO_2_1_stdout_>, is_pager=is_pager@entry=0 '\000', flog=0x0) at print.c:3551

#5  0x000000000040da6d in PrintQueryTuples (results=0x9c4b60) at common.c:808

#6  PrintQueryResults (results=0x9c4b60) at common.c:1140

#7  SendQuery (query=0x9c1700 "select 10;") at common.c:1317

#8  0x000000000041c3d4 in MainLoop (source=0x7f77677248a0 <_IO_2_1_stdin_>) at mainloop.c:319

#9  0x0000000000405d5d in main (argc=<optimized out>, argv=<optimized out>) at startup.c:396

Regards

Pavel

 

Jan

 

Have nice day

Jan

 

Thanks !

The new status of this patch is: Waiting on Author

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

--

Jelen

Starší čeledín datovýho chlíva

--

Jelen

Starší čeledín datovýho chlíva

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers