Thread: [pgsql-pkg-yum] pgadmin4 RPM broken?

Hi John,

Wow, I was sure that I tested this, but apparently I did not. I see your point.
Actually the recent spec file in the repo should be good (as a part of some new
repo announcement), so I need to rebuild pgadmin4 RPM using that spec file.

Will do.

Regards, Devrim

On Mon, 2017-04-24 at 09:37 -0400, John Harvey wrote:
> Hello Devrim,
>
> I know that pgadmin4 is being overhauled, but it looks like the current yum
> installation is broken.
>
> I just tried the following procedure:
>
>    1. Create a Centos7 VM
>    2. sudo yum -y install
>    https://download.postgresql.org/pub/repos/yum/9.5/redhat/rhel-7-x86_64/pgd
> g-centos95-9.5-3.noarch.rpm
>    3. sudo yum install pgadmin4-v1-web
>
> When I do this, I get a lot of errors about missing python-* packages.  I
> know that rencently, the python-* dependencies were changed to a prefix of
> pgadmin4-python.  This all worked fine until the python-* packages were
> removed from the yum repository.  When that happened, the currently-posted
> pgadmin4 is based on a specfile that still has Requires lines referencing
> the old dependency package structure, that are now missing.
>
> As a quick example, take a look at:
> pgrpms/rpm/redhat/9.5/pgadmin4-v1/EL-7/ pgadmin4-v1.spec
>
> This specfile still has a bunch of Requires lines for
> Requires:       python3-babel >= 1.3
> Requires:       python3-flask >= 0.11.1
> etc.
>
> I know there's a FIXME written to do the work, but if that is going to take
> some time to do, I might request that the python-* packages be restored
> temporarily so that the current version of pgadmin4 on the yum repository
> will be able to install properly.
>
> Regards,
>   -John Harvey

--
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Hi John,

On Thu, 2017-04-27 at 17:38 -0400, John Harvey wrote:

> No worries.  I know that things have been busy.

Yeah :/

> BTW, I did some test building with the latest spec on RHEL7, since you
> mentioned you're thinking of a rebuild/re-release.

Thanks!

> I had a few findings that may be of use, if you are still finalizing the
> spec-file.

Patches always welcome. I shuffled the spec file * a lot * , I'm sure I may
have missed something.

> Some of these are small and have to do with a few of the new
> pgadmin4-python packages.
>
> 1) I noticed that there is no pgadmin4-babel directory in the 9.5 folder,
> but it exists in 9.6.  Does it make sense to copy that over to 9.5 (and
> pg10) as well?  It is a necessary build dependency
> for pgadmin4-python-flask-babel.

Right, I'll do that.

> 2) Do you think it makes sense to change the name of the pgadmin4-babel
> specfile (babel.spec) to pgadmin4-babel.spec to match the other pgadmin4
> specfile naming conventions?

Thanks, done.
>
> 3) In the yum repository, one of the pgadmin4-python RPM's has some strange
> capitalization in the RPM name:
> pgadmin4-python-Flask-Mail-0.9.1-3.rhel6.noarch.rpm.
> Should this all be lowercase?

I think this comes from the tarball. I'll leave it as is for now.

> 4) When I try building with the current pgadmin4 specfile on RHEL7, I get
> an error at patch-time:
>
> + cd pgadmin4-1.3
> + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> + echo 'Patch #0 (pgadmin4-sphinx-theme.patch):'
> Patch #0 (pgadmin4-sphinx-theme.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-sphinx-theme.patch
> + /usr/bin/patch -p0 --fuzz=0
> patching file docs/en_US/conf.py
> + echo 'Patch #4 (pgadmin4-rhel7-sphinx.patch):'
> Patch #4 (pgadmin4-rhel7-sphinx.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-rhel7-sphinx.patch
> + /usr/bin/patch -p0 --fuzz=0
> patching file docs/en_US/Makefile.sphinx
> Reversed (or previously applied) patch detected!  Assume -R? [n]
>
>
> I'm not sure why this occurs.  I'll keep investigating.

Can't reproduce -- can you please clean up your repo and try again?

> 5) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-flask-mail
> Without it (assuming I remove the patch line from my issue 4 above), I see
> this when I compile pgadmin4:

<snip>

Done.

> 6) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-dateutil

Done.

>
> 7) I think the pgadmin4 specfile may need the following line:
> BuildRequires: pgadmin4-python-flask-gravatar

Done.

> I hope these are helpful.

Thank you, they are very useful!

Regards,
--
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

Hi John,

On Fri, 2017-04-28 at 16:05 -0400, John Harvey wrote:
> I found two more specfile recommendations today after some more testing:
>
> 1) I would suggest adding "BuildRequires: pgadmin4-python-simplejson" to
> the pgadmin4 specfile.
>
> Without it, I see this trace in the build log:

<snip>

Added.


> 2) I think that two Requires lines may need to change, specifically around
> python-itsdangerous
>
> Requires:       python3-itsdangerous >= 0.24
> Requires:       python-itsdangerous >= 0.24
>
> On CentOS 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @extras packages
> On RHEL 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @rhel-7-server-extras-rpms packages
> Unfortunately, these are too low of a version.  I'm guessing we want to use
> the PGDG-built version.
>
> I think that these lines should actually now be moved to:
> Requires:       pgadmin4-python-itsdangerous >= 0.24
>
> Is that a correct assumption?

I changed Python2 part only, and that was a great catch. Thanks!

The new spec file is in the repo now. Thanks for looking at this, it was great!

Regards,
--
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR