Hi John,
On Fri, 2017-04-28 at 16:05 -0400, John Harvey wrote:
> I found two more specfile recommendations today after some more testing:
>
> 1) I would suggest adding "BuildRequires: pgadmin4-python-simplejson" to
> the pgadmin4 specfile.
>
> Without it, I see this trace in the build log:
<snip>
Added.
> 2) I think that two Requires lines may need to change, specifically around
> python-itsdangerous
>
> Requires: python3-itsdangerous >= 0.24
> Requires: python-itsdangerous >= 0.24
>
> On CentOS 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @extras packages
> On RHEL 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @rhel-7-server-extras-rpms packages
> Unfortunately, these are too low of a version. I'm guessing we want to use
> the PGDG-built version.
>
> I think that these lines should actually now be moved to:
> Requires: pgadmin4-python-itsdangerous >= 0.24
>
> Is that a correct assumption?
I changed Python2 part only, and that was a great catch. Thanks!
The new spec file is in the repo now. Thanks for looking at this, it was great!
Regards,
--
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
