Hi John,
On Thu, 2017-04-27 at 17:38 -0400, John Harvey wrote:
> No worries. I know that things have been busy.
Yeah :/
> BTW, I did some test building with the latest spec on RHEL7, since you
> mentioned you're thinking of a rebuild/re-release.
Thanks!
> I had a few findings that may be of use, if you are still finalizing the
> spec-file.
Patches always welcome. I shuffled the spec file * a lot * , I'm sure I may
have missed something.
> Some of these are small and have to do with a few of the new
> pgadmin4-python packages.
>
> 1) I noticed that there is no pgadmin4-babel directory in the 9.5 folder,
> but it exists in 9.6. Does it make sense to copy that over to 9.5 (and
> pg10) as well? It is a necessary build dependency
> for pgadmin4-python-flask-babel.
Right, I'll do that.
> 2) Do you think it makes sense to change the name of the pgadmin4-babel
> specfile (babel.spec) to pgadmin4-babel.spec to match the other pgadmin4
> specfile naming conventions?
Thanks, done.
>
> 3) In the yum repository, one of the pgadmin4-python RPM's has some strange
> capitalization in the RPM name:
> pgadmin4-python-Flask-Mail-0.9.1-3.rhel6.noarch.rpm.
> Should this all be lowercase?
I think this comes from the tarball. I'll leave it as is for now.
> 4) When I try building with the current pgadmin4 specfile on RHEL7, I get
> an error at patch-time:
>
> + cd pgadmin4-1.3
> + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> + echo 'Patch #0 (pgadmin4-sphinx-theme.patch):'
> Patch #0 (pgadmin4-sphinx-theme.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-sphinx-theme.patch
> + /usr/bin/patch -p0 --fuzz=0
> patching file docs/en_US/conf.py
> + echo 'Patch #4 (pgadmin4-rhel7-sphinx.patch):'
> Patch #4 (pgadmin4-rhel7-sphinx.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-rhel7-sphinx.patch
> + /usr/bin/patch -p0 --fuzz=0
> patching file docs/en_US/Makefile.sphinx
> Reversed (or previously applied) patch detected! Assume -R? [n]
>
>
> I'm not sure why this occurs. I'll keep investigating.
Can't reproduce -- can you please clean up your repo and try again?
> 5) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-flask-mail
> Without it (assuming I remove the patch line from my issue 4 above), I see
> this when I compile pgadmin4:
<snip>
Done.
> 6) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-dateutil
Done.
>
> 7) I think the pgadmin4 specfile may need the following line:
> BuildRequires: pgadmin4-python-flask-gravatar
Done.
> I hope these are helpful.
Thank you, they are very useful!
Regards,
--
Devrim Gündüz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
