Thread: Commit fest 2022-11

Hi all,

As per the world clock, the next commit fest will begin in 30 hours
(11/1 0:00 AoE time).  I may have missed something, but it looks like
we have no CFM for this one yet.

Opinions, thoughts or volunteers?
--
Michael

2022年10月31日(月) 14:42 Michael Paquier <michael@paquier.xyz>:
>
> Hi all,
>
> As per the world clock, the next commit fest will begin in 30 hours
> (11/1 0:00 AoE time).  I may have missed something, but it looks like
> we have no CFM for this one yet.

** tumbleweed **

> Opinions, thoughts or volunteers?

This is on my bucket list of things to do some day, so I guess now is as bad a
time as any :). Caveat is that this will have to be a personal
free-time project,
so would be good if someone else is around as well.

Regards

Ian Barwick

On Tue, Nov 01, 2022 at 09:56:47AM +0530, jian he wrote:
> I am free. I can help.

Commit fest managers are usually people who have a few years of
experience behind the community process.  There are plenty of patches
to review, so feel free to pick up a few things and help moving these,
of course!  Thanks.
--
Michael

On Tue, Nov 01, 2022 at 10:01:05AM +0900, Ian Lawrence Barwick wrote:
> This is on my bucket list of things to do some day, so I guess now is as bad a
> time as any :). Caveat is that this will have to be a personal
> free-time project,
> so would be good if someone else is around as well.

Don't worry, we all have priorities.  I'll be around, so I'll help you
with all that, switching the status of the CF in a couple of hours.

(Let's discuss in person if necessary next week, I guess?)
--
Michael

On Mon, 31 Oct 2022 at 05:42, Michael Paquier <michael@paquier.xyz> wrote:

> As per the world clock, the next commit fest will begin in 30 hours
> (11/1 0:00 AoE time).  I may have missed something, but it looks like
> we have no CFM for this one yet.
>
> Opinions, thoughts or volunteers?

If we have no volunteers, maybe it is because the job of CFM is too
big now and needs to be split.

I can offer to be co-CFM, and think I can offer to be CFM for about
100 patches, but I don't have the time to do the whole thing myself.

-- 
Simon Riggs                http://www.EnterpriseDB.com/

2022年11月1日(火) 13:40 Michael Paquier <michael@paquier.xyz>:
>
> On Tue, Nov 01, 2022 at 10:01:05AM +0900, Ian Lawrence Barwick wrote:
> > This is on my bucket list of things to do some day, so I guess now is as bad a
> > time as any :). Caveat is that this will have to be a personal
> > free-time project,
> > so would be good if someone else is around as well.
>
> Don't worry, we all have priorities.  I'll be around, so I'll help you
> with all that, switching the status of the CF in a couple of hours.
>
> (Let's discuss in person if necessary next week, I guess?)

Yup, Monday by the looks of it.

My community login is "barwick", in case needed.

Regards

Ian Barwick

2022年11月1日(火) 17:59 Simon Riggs <simon.riggs@enterprisedb.com>:
>
> On Mon, 31 Oct 2022 at 05:42, Michael Paquier <michael@paquier.xyz> wrote:
>
> > As per the world clock, the next commit fest will begin in 30 hours
> > (11/1 0:00 AoE time).  I may have missed something, but it looks like
> > we have no CFM for this one yet.
> >
> > Opinions, thoughts or volunteers?
>
> If we have no volunteers, maybe it is because the job of CFM is too
> big now and needs to be split.

From casual observation it's been like that for the last few CFs, i.e. there
have been effectively two CFMs.

I am on record as volunteering earlier in the thread, with the caveat that there
will be a limit on what I can do :).


Regards

Ian Barwick

On Tue, Nov 01, 2022 at 07:15:34PM +0900, Ian Lawrence Barwick wrote:
> From casual observation it's been like that for the last few CFs, i.e. there
> have been effectively two CFMs.
>
> I am on record as volunteering earlier in the thread, with the caveat that there
> will be a limit on what I can do :).

Two people showing up to help is really great, thanks!  I'll be around
as well this month, so I'll do my share of patches, as usual.
--
Michael

On Tue, Nov 01, 2022 at 07:10:15PM +0900, Ian Lawrence Barwick wrote:
> Yup, Monday by the looks of it.
>
> My community login is "barwick", in case needed.

Adding Magnus in CC, in case you need the admin permissions on the CF
app.  (I have no idea how to do it, and I likely lack the permissions
to do that anyway.)
--
Michael

2022年11月2日(水) 1:36 Magnus Hagander <magnus@hagander.net>:>
> On Tue, Nov 1, 2022 at 11:59 AM Michael Paquier <michael@paquier.xyz> wrote:
>>
>> On Tue, Nov 01, 2022 at 07:10:15PM +0900, Ian Lawrence Barwick wrote:
>> > Yup, Monday by the looks of it.
>> >
>> > My community login is "barwick", in case needed.
>>
>> Adding Magnus in CC, in case you need the admin permissions on the CF
>> app.  (I have no idea how to do it, and I likely lack the permissions
>> to do that anyway.)
>>
>
> Permissions added!

Thanks, I see the extra menu link.

Regards

Ian Barwick

On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:

> Two people showing up to help is really great, thanks!  I'll be around
> as well this month, so I'll do my share of patches, as usual.

Fwiw I can help as well -- starting next week. I can't do much this week though.

I would suggest starting with the cfbot to mark anything that isn't
applying cleanly and passing tests (and looking for more than design
feedback) as Waiting on Author and reminding the author that it's
commitfest time and a good time to bring the patch into a clean state.

-- 
greg

2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
>
> On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
>
> > Two people showing up to help is really great, thanks!  I'll be around
> > as well this month, so I'll do my share of patches, as usual.
>
> Fwiw I can help as well -- starting next week. I can't do much this week though.
>
> I would suggest starting with the cfbot to mark anything that isn't
> applying cleanly and passing tests (and looking for more than design
> feedback) as Waiting on Author and reminding the author that it's
> commitfest time and a good time to bring the patch into a clean state.

Sounds like a plan; I'll make a start on that today/tomorrow as I have
some time.

Regards

Ian Barwick

2022年11月3日(木) 11:33 Ian Lawrence Barwick <barwick@gmail.com>:
>
> 2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
> >
> > On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
> >
> > > Two people showing up to help is really great, thanks!  I'll be around
> > > as well this month, so I'll do my share of patches, as usual.
> >
> > Fwiw I can help as well -- starting next week. I can't do much this week though.
> >
> > I would suggest starting with the cfbot to mark anything that isn't
> > applying cleanly and passing tests (and looking for more than design
> > feedback) as Waiting on Author and reminding the author that it's
> > commitfest time and a good time to bring the patch into a clean state.
>
> Sounds like a plan; I'll make a start on that today/tomorrow as I have
> some time.

Ploughing through the list, initially those where the patches don't apply.

I am wondering what the best thing to do with cases like this is:

    https://commitfest.postgresql.org/40/3977/

where there were multiple patches in the original post, and some but not all
were applied - so those ones are now failing to apply in the cfbot. Should we
request the author to update the thread with those patches which are
still pending?

Regards

Ian Barwick

On Thu, Nov 03, 2022 at 06:48:34PM +0900, Ian Lawrence Barwick wrote:
> I am wondering what the best thing to do with cases like this is:
>
>     https://commitfest.postgresql.org/40/3977/
>
> where there were multiple patches in the original post, and some but not all
> were applied - so those ones are now failing to apply in the cfbot. Should we
> request the author to update the thread with those patches which are
> still pending?

A case-by-case analysis is usually adapted, but if subject is not over
yet, and only a portion of the patches have been addressed, keeping it
around is the best course of action IMO.  The author and/or reviewer
may decide otherwise later on, or the patch could always be revisited
at the end of the CF and marked as committed, though it would be good
to update the thread to reflect that.  By experience, it does not
happen that often.
--
Michael

On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote:
> 2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
> >
> > On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
> >
> > > Two people showing up to help is really great, thanks!  I'll be around
> > > as well this month, so I'll do my share of patches, as usual.
> >
> > Fwiw I can help as well -- starting next week. I can't do much this week though.
> >
> > I would suggest starting with the cfbot to mark anything that isn't
> > applying cleanly and passing tests (and looking for more than design
> > feedback) as Waiting on Author and reminding the author that it's
> > commitfest time and a good time to bring the patch into a clean state.
> 
> Sounds like a plan; I'll make a start on that today/tomorrow as I have
> some time.

If I'm not wrong, Jacob used the CF app to bulk-mail people about
patches not applying and similar things.  That seemed to work well, and
doesn't require sending mails to dozens of threads.

-- 
Justin

2022年11月4日(金) 9:43 Justin Pryzby <pryzby@telsasoft.com>:
>
> On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote:
> > 2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
> > >
> > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
> > >
> > > > Two people showing up to help is really great, thanks!  I'll be around
> > > > as well this month, so I'll do my share of patches, as usual.
> > >
> > > Fwiw I can help as well -- starting next week. I can't do much this week though.
> > >
> > > I would suggest starting with the cfbot to mark anything that isn't
> > > applying cleanly and passing tests (and looking for more than design
> > > feedback) as Waiting on Author and reminding the author that it's
> > > commitfest time and a good time to bring the patch into a clean state.
> >
> > Sounds like a plan; I'll make a start on that today/tomorrow as I have
> > some time.
>
> If I'm not wrong, Jacob used the CF app to bulk-mail people about
> patches not applying and similar things.  That seemed to work well, and
> doesn't require sending mails to dozens of threads.

I don't see anything like that in the CF app (though I may be looking in the
wrong place).  I also don't see how it would be possible to filter on patches
not applying in cbfot, as AFAICT the former is not aware of the latter.

There is an option for each entry to send an email from the CF app, but it comes
with a note "Please ensure that the email settings for your domain (DKIM, SPF)
allow emails from external sources." which I fear would lead to email
delivery issues.

Regards

Ian Barwick

On 11/3/22 22:18, Ian Lawrence Barwick wrote:
> 2022年11月4日(金) 10:23 Ian Lawrence Barwick <barwick@gmail.com
> <mailto:barwick@gmail.com>>:
>> 2022年11月4日(金) 9:43 Justin Pryzby <pryzby@telsasoft.com
> <mailto:pryzby@telsasoft.com>>:
>> > If I'm not wrong, Jacob used the CF app to bulk-mail people about
>> > patches not applying and similar things.  That seemed to work well, and
>> > doesn't require sending mails to dozens of threads.
>>
>> I don't see anything like that in the CF app (though I may be looking in the
>> wrong place).

I just used the "email author" checkboxes.

>> I also don't see how it would be possible to filter on patches
>> not applying in cbfot, as AFAICT the former is not aware of the latter.

That was the hard part. I ended up manually merging the two pages locally.

> Also, having gone through all the cfbot items with non-applying 
> patches (single red "X"), sending a reminder without checking
> further doesn't seem the right thing tod do - in two cases the patch
> was not applying because it had already been committed, and with
> another the consensus was to return it with feedback. With others,
> it's obvious the threads were recently active and I don't think a
> reminder is necessary right now.

True. One nice thing about the author-only email is that, as long as you
don't send reminders too often (I think there'd been talk before of
once, maximum twice, per CF?) then if an author feels there's no reason
to take action, they don't have to. That low-effort strategy also scales
a bit better than making a CFM scan manually, and it's a bit closer in
my opinion to the automated reminder feature that's been requested
frequently.

> There is an option for each entry to send an email from the CF app, but it comes
> with a note "Please ensure that the email settings for your domain (DKIM, SPF)
> allow emails from external sources." which I fear would lead to email
> delivery issues.

I know some of my bulk emails were delivered to spam folders, so it is a
fair concern.

--Jacob

On Thu, Nov 03, 2022 at 07:43:03PM -0500, Justin Pryzby wrote:
> On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote:
> > 2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
> > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
> > >
> > > > Two people showing up to help is really great, thanks!  I'll be around
> > > > as well this month, so I'll do my share of patches, as usual.
> > >
> > > Fwiw I can help as well -- starting next week. I can't do much this week though.
> > >
> > > I would suggest starting with the cfbot to mark anything that isn't
> > > applying cleanly and passing tests (and looking for more than design
> > > feedback) as Waiting on Author and reminding the author that it's
> > > commitfest time and a good time to bring the patch into a clean state.
> > 
> > Sounds like a plan; I'll make a start on that today/tomorrow as I have
> > some time.
> 
> If I'm not wrong, Jacob used the CF app to bulk-mail people about
> patches not applying and similar things.  That seemed to work well, and
> doesn't require sending mails to dozens of threads.

If my script is not wrong, these patches add TAP tests, but don't update
the requisite ./meson.build file.  It seems like it'd be reasonable to
set them all as WOA until that's done.

$ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary "$a"`; echo
"$x"|grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log -1 --oneline
"$a";done
 
... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
... [CF 40/3646] Skip replicating the tables specified in except table option
... [CF 40/3663] Switching XLog source from archive to streaming when primary available
... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
... [CF 40/3729] Testing autovacuum wraparound
... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
... [CF 40/3985] TDE key management patches

-- 
Justin

2022年11月9日(水) 8:12 Justin Pryzby <pryzby@telsasoft.com>:
>
> On Thu, Nov 03, 2022 at 07:43:03PM -0500, Justin Pryzby wrote:
> > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote:
> > > 2022年11月2日(水) 19:10 Greg Stark <stark@mit.edu>:
> > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier <michael@paquier.xyz> wrote:
> > > >
> > > > > Two people showing up to help is really great, thanks!  I'll be around
> > > > > as well this month, so I'll do my share of patches, as usual.
> > > >
> > > > Fwiw I can help as well -- starting next week. I can't do much this week though.
> > > >
> > > > I would suggest starting with the cfbot to mark anything that isn't
> > > > applying cleanly and passing tests (and looking for more than design
> > > > feedback) as Waiting on Author and reminding the author that it's
> > > > commitfest time and a good time to bring the patch into a clean state.
> > >
> > > Sounds like a plan; I'll make a start on that today/tomorrow as I have
> > > some time.
> >
> > If I'm not wrong, Jacob used the CF app to bulk-mail people about
> > patches not applying and similar things.  That seemed to work well, and
> > doesn't require sending mails to dozens of threads.
>
> If my script is not wrong, these patches add TAP tests, but don't update
> the requisite ./meson.build file.  It seems like it'd be reasonable to
> set them all as WOA until that's done.
>
> $ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary "$a"`; echo
"$x"|grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log -1 --oneline
"$a";done 
> ... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
> ... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
> ... [CF 40/3646] Skip replicating the tables specified in except table option
> ... [CF 40/3663] Switching XLog source from archive to streaming when primary available
> ... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
> ... [CF 40/3729] Testing autovacuum wraparound
> ... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
> ... [CF 40/3985] TDE key management patches

Looks like your script is correct, will update accordingly.

Do we have a FAQ/checklist of meson things to consider for patches anywhere?

Regards

Ian Barwick

On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick <barwick@gmail.com> wrote:
>
> 2022年11月9日(水) 8:12 Justin Pryzby <pryzby@telsasoft.com>:
....
> > If my script is not wrong, these patches add TAP tests, but don't update
> > the requisite ./meson.build file.  It seems like it'd be reasonable to
> > set them all as WOA until that's done.
> >
> > $ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary "$a"`;
echo"$x" |grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log -1
--oneline"$a"; done 
> > ... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
> > ... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
> > ... [CF 40/3646] Skip replicating the tables specified in except table option
> > ... [CF 40/3663] Switching XLog source from archive to streaming when primary available
> > ... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
> > ... [CF 40/3729] Testing autovacuum wraparound
> > ... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
> > ... [CF 40/3985] TDE key management patches
>
> Looks like your script is correct, will update accordingly.
>
> Do we have a FAQ/checklist of meson things to consider for patches anywhere?

It's possible this has been discussed before, but it seems less than
ideal to have notifications about moving to WOA be sent only in a bulk
email hanging off the "current CF" email chain as opposed to being
sent to the individual threads. Perhaps that's something the app
should do for us in this situation. Without that though the patch
authors are left to wade through unrelated discussion, and, probably
more importantly, the patch discussion thread doesn't show the current
state (I think bumping there is more likely to prompt activity as
well).

James Coleman

2022年11月14日(月) 22:23 James Coleman <jtc331@gmail.com>:
>
> On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick <barwick@gmail.com> wrote:
> >
> > 2022年11月9日(水) 8:12 Justin Pryzby <pryzby@telsasoft.com>:
> ....
> > > If my script is not wrong, these patches add TAP tests, but don't update
> > > the requisite ./meson.build file.  It seems like it'd be reasonable to
> > > set them all as WOA until that's done.
> > >
> > > $ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary "$a"`;
echo"$x" |grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log -1
--oneline"$a"; done 
> > > ... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
> > > ... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
> > > ... [CF 40/3646] Skip replicating the tables specified in except table option
> > > ... [CF 40/3663] Switching XLog source from archive to streaming when primary available
> > > ... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
> > > ... [CF 40/3729] Testing autovacuum wraparound
> > > ... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
> > > ... [CF 40/3985] TDE key management patches
> >
> > Looks like your script is correct, will update accordingly.
> >
>
> It's possible this has been discussed before, but it seems less than
> ideal to have notifications about moving to WOA be sent only in a bulk
> email hanging off the "current CF" email chain as opposed to being
> sent to the individual threads. Perhaps that's something the app
> should do for us in this situation. Without that though the patch
> authors are left to wade through unrelated discussion, and, probably
> more importantly, the patch discussion thread doesn't show the current
> state (I think bumping there is more likely to prompt activity as
> well).

FWIW I've been manually "bumping" the respective threads, which is somewhat
time-consuming but seems to have been quite productive in terms of getting
patches updated.

Will do same for the above once I've confirmed what is being requested,
(which I presume is adding the new tests to the 'tests' array in the respective
"meson.build" file; just taking the opportunity to familiariize myself with it).

Regards

Ian Barwick

2022年11月14日(月) 22:38 Ian Lawrence Barwick <barwick@gmail.com>:
>
> 2022年11月14日(月) 22:23 James Coleman <jtc331@gmail.com>:
> >
> > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick <barwick@gmail.com> wrote:
> > >
> > > 2022年11月9日(水) 8:12 Justin Pryzby <pryzby@telsasoft.com>:
> > ....
> > > > If my script is not wrong, these patches add TAP tests, but don't update
> > > > the requisite ./meson.build file.  It seems like it'd be reasonable to
> > > > set them all as WOA until that's done.
> > > >
> > > > $ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary "$a"`;
echo"$x" |grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log -1
--oneline"$a"; done 
> > > > ... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
> > > > ... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
> > > > ... [CF 40/3646] Skip replicating the tables specified in except table option
> > > > ... [CF 40/3663] Switching XLog source from archive to streaming when primary available
> > > > ... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
> > > > ... [CF 40/3729] Testing autovacuum wraparound
> > > > ... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
> > > > ... [CF 40/3985] TDE key management patches
> > >
> > > Looks like your script is correct, will update accordingly.
> > >
> >
> > It's possible this has been discussed before, but it seems less than
> > ideal to have notifications about moving to WOA be sent only in a bulk
> > email hanging off the "current CF" email chain as opposed to being
> > sent to the individual threads. Perhaps that's something the app
> > should do for us in this situation. Without that though the patch
> > authors are left to wade through unrelated discussion, and, probably
> > more importantly, the patch discussion thread doesn't show the current
> > state (I think bumping there is more likely to prompt activity as
> > well).
>
> FWIW I've been manually "bumping" the respective threads, which is somewhat
> time-consuming but seems to have been quite productive in terms of getting
> patches updated.
>
> Will do same for the above once I've confirmed what is being requested,
> (which I presume is adding the new tests to the 'tests' array in the respective
> "meson.build" file; just taking the opportunity to familiariize myself with it).

Various mails since sent to the appropriate threads; I took the opportunity
to create a short wiki page:

   https://wiki.postgresql.org/wiki/Meson_for_patch_authors

with relevant details (AFAICS) for anyone not familiar with meson; corrections/
improvements welcome.

In the meantime I notice a number of patches in cfbot are currently failing on
TAP test "test_custom_rmgrs/t/001_basic.pl" in some environments. This was
added the other day in commit ae168c794f; there is already a fix for the issue
( 36e0358e70 ) but the cfbot doesn't have that commit yet.

Regards

Ian Barwick

Hi,

The Commitfest 2022-11 status still shows as "In Progress", Shouldn't
the status be changed to "Closed" and the entries be moved to the next
commitfest.

Regards,
Vignesh

On Wed, 16 Nov 2022 at 18:30, Ian Lawrence Barwick <barwick@gmail.com> wrote:
>
> 2022年11月14日(月) 22:38 Ian Lawrence Barwick <barwick@gmail.com>:
> >
> > 2022年11月14日(月) 22:23 James Coleman <jtc331@gmail.com>:
> > >
> > > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick <barwick@gmail.com> wrote:
> > > >
> > > > 2022年11月9日(水) 8:12 Justin Pryzby <pryzby@telsasoft.com>:
> > > ....
> > > > > If my script is not wrong, these patches add TAP tests, but don't update
> > > > > the requisite ./meson.build file.  It seems like it'd be reasonable to
> > > > > set them all as WOA until that's done.
> > > > >
> > > > > $ for a in `git branch -a |sort |grep commitfest/40`; do : echo "$a..."; x=`git log -1 --compact-summary
"$a"`;echo "$x" |grep '/t/.*pl.*new' >/dev/null || continue; echo "$x" |grep -Fw meson >/dev/null && continue; git log
-1--oneline "$a"; done 
> > > > > ... [CF 40/3558] Allow file inclusion in pg_hba and pg_ident files
> > > > > ... [CF 40/3628] Teach pg_waldump to extract FPIs from the WAL stream
> > > > > ... [CF 40/3646] Skip replicating the tables specified in except table option
> > > > > ... [CF 40/3663] Switching XLog source from archive to streaming when primary available
> > > > > ... [CF 40/3670] pg_rewind: warn when checkpoint hasn't happened after promotion
> > > > > ... [CF 40/3729] Testing autovacuum wraparound
> > > > > ... [CF 40/3877] vacuumlo: add test to vacuumlo for test coverage
> > > > > ... [CF 40/3985] TDE key management patches
> > > >
> > > > Looks like your script is correct, will update accordingly.
> > > >
> > >
> > > It's possible this has been discussed before, but it seems less than
> > > ideal to have notifications about moving to WOA be sent only in a bulk
> > > email hanging off the "current CF" email chain as opposed to being
> > > sent to the individual threads. Perhaps that's something the app
> > > should do for us in this situation. Without that though the patch
> > > authors are left to wade through unrelated discussion, and, probably
> > > more importantly, the patch discussion thread doesn't show the current
> > > state (I think bumping there is more likely to prompt activity as
> > > well).
> >
> > FWIW I've been manually "bumping" the respective threads, which is somewhat
> > time-consuming but seems to have been quite productive in terms of getting
> > patches updated.
> >
> > Will do same for the above once I've confirmed what is being requested,
> > (which I presume is adding the new tests to the 'tests' array in the respective
> > "meson.build" file; just taking the opportunity to familiariize myself with it).
>
> Various mails since sent to the appropriate threads; I took the opportunity
> to create a short wiki page:
>
>    https://wiki.postgresql.org/wiki/Meson_for_patch_authors
>
> with relevant details (AFAICS) for anyone not familiar with meson; corrections/
> improvements welcome.
>
> In the meantime I notice a number of patches in cfbot are currently failing on
> TAP test "test_custom_rmgrs/t/001_basic.pl" in some environments. This was
> added the other day in commit ae168c794f; there is already a fix for the issue
> ( 36e0358e70 ) but the cfbot doesn't have that commit yet.
>
> Regards
>
> Ian Barwick

On Wed, Dec 07, 2022 at 08:25:25AM +0530, vignesh C wrote:
> The Commitfest 2022-11 status still shows as "In Progress", Shouldn't
> the status be changed to "Closed" and the entries be moved to the next
> commitfest.

Yes, Ian has told me that he is on it this week.
--
Michael