Thread: TM formating patch
Hello, I am sorry for preview chotic mails. My web email client is stupid (I am too). This patch correct bug, when localized day or month names was incorectly trnasformed to lower or upper string. Regards Pavel Stehule _________________________________________________________________ Najdete si svou lasku a nove pratele na Match.com. http://www.msn.cz/
Attachment
"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> This patch correct bug, when localized day or month names was incorectly
> trnasformed to lower or upper string.
I really dislike the API you've chosen for upper_str/lower_str ---
overwriting the input on the assumption that it's long enough is a
buffer overrun bug waiting to happen, because (at least in utf8)
changing case doesn't preserve the byte length of the string.
Please make them return a freshly palloc'd string instead.
regards, tom lane
>"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > This patch correct bug, when localized day or month names was incorectly > > trnasformed to lower or upper string. > >I really dislike the API you've chosen for upper_str/lower_str --- >overwriting the input on the assumption that it's long enough is a >buffer overrun bug waiting to happen, because (at least in utf8) >changing case doesn't preserve the byte length of the string. >Please make them return a freshly palloc'd string instead. > > regards, tom lane I correct it, and test it for czech latin2 and utf8 case. Regards Pavel Stehule _________________________________________________________________ Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/
Attachment
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Pavel Stehule wrote:
> >"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> > > This patch correct bug, when localized day or month names was incorectly
> > > trnasformed to lower or upper string.
> >
> >I really dislike the API you've chosen for upper_str/lower_str ---
> >overwriting the input on the assumption that it's long enough is a
> >buffer overrun bug waiting to happen, because (at least in utf8)
> >changing case doesn't preserve the byte length of the string.
> >Please make them return a freshly palloc'd string instead.
> >
> > regards, tom lane
>
> I correct it, and test it for czech latin2 and utf8 case.
>
> Regards
> Pavel Stehule
>
> _________________________________________________________________
> Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/
[ Attachment, skipping... ]
>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
> http://www.postgresql.org/docs/faq
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
Patch applied. Thanks. I have not backpatched it to 8.2.X because I am unclear of the risk involved. Suggestions? --------------------------------------------------------------------------- Pavel Stehule wrote: > >"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > > This patch correct bug, when localized day or month names was incorectly > > > trnasformed to lower or upper string. > > > >I really dislike the API you've chosen for upper_str/lower_str --- > >overwriting the input on the assumption that it's long enough is a > >buffer overrun bug waiting to happen, because (at least in utf8) > >changing case doesn't preserve the byte length of the string. > >Please make them return a freshly palloc'd string instead. > > > > regards, tom lane > > I correct it, and test it for czech latin2 and utf8 case. > > Regards > Pavel Stehule > > _________________________________________________________________ > Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/ [ Attachment, skipping... ] > > ---------------------------(end of broadcast)--------------------------- > TIP 3: Have you checked our extensive FAQ? > > http://www.postgresql.org/docs/faq -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +
>Patch applied. Thanks. > >I have not backpatched it to 8.2.X because I am unclear of the risk >involved. Suggestions? It's bug in 8.2. I don't know about any risks for 8.2 Pavel > >--------------------------------------------------------------------------- > > >Pavel Stehule wrote: > > >"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > > > This patch correct bug, when localized day or month names was >incorectly > > > > trnasformed to lower or upper string. > > > > > >I really dislike the API you've chosen for upper_str/lower_str --- > > >overwriting the input on the assumption that it's long enough is a > > >buffer overrun bug waiting to happen, because (at least in utf8) > > >changing case doesn't preserve the byte length of the string. > > >Please make them return a freshly palloc'd string instead. > > > > > > regards, tom lane > > > > I correct it, and test it for czech latin2 and utf8 case. > > > > Regards > > Pavel Stehule > > > > _________________________________________________________________ > > Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/ > >[ Attachment, skipping... ] > > > > > ---------------------------(end of broadcast)--------------------------- > > TIP 3: Have you checked our extensive FAQ? > > > > http://www.postgresql.org/docs/faq > >-- > Bruce Momjian <bruce@momjian.us> http://momjian.us > EnterpriseDB http://www.enterprisedb.com > > + If your life is a hard drive, Christ can be your backup. + _________________________________________________________________ Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. http://messenger.msn.cz/
Pavel Stehule wrote: > > >Patch applied. Thanks. > > > >I have not backpatched it to 8.2.X because I am unclear of the risk > >involved. Suggestions? > > It's bug in 8.2. I don't know about any risks for 8.2 OK, I have backpatched it to 8.2.X. --------------------------------------------------------------------------- > > Pavel > > > > >--------------------------------------------------------------------------- > > > > > >Pavel Stehule wrote: > > > >"Pavel Stehule" <pavel.stehule@hotmail.com> writes: > > > > > This patch correct bug, when localized day or month names was > >incorectly > > > > > trnasformed to lower or upper string. > > > > > > > >I really dislike the API you've chosen for upper_str/lower_str --- > > > >overwriting the input on the assumption that it's long enough is a > > > >buffer overrun bug waiting to happen, because (at least in utf8) > > > >changing case doesn't preserve the byte length of the string. > > > >Please make them return a freshly palloc'd string instead. > > > > > > > > regards, tom lane > > > > > > I correct it, and test it for czech latin2 and utf8 case. > > > > > > Regards > > > Pavel Stehule > > > > > > _________________________________________________________________ > > > Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/ > > > >[ Attachment, skipping... ] > > > > > > > > ---------------------------(end of broadcast)--------------------------- > > > TIP 3: Have you checked our extensive FAQ? > > > > > > http://www.postgresql.org/docs/faq > > > >-- > > Bruce Momjian <bruce@momjian.us> http://momjian.us > > EnterpriseDB http://www.enterprisedb.com > > > > + If your life is a hard drive, Christ can be your backup. + > > _________________________________________________________________ > Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci. > http://messenger.msn.cz/ -- Bruce Momjian <bruce@momjian.us> http://momjian.us EnterpriseDB http://www.enterprisedb.com + If your life is a hard drive, Christ can be your backup. +