Re: TM formating patch - Mailing list pgsql-patches

From Tom Lane
Subject Re: TM formating patch
Date
Msg-id 116.1170691348@sss.pgh.pa.us
Whole thread Raw
In response to TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
List pgsql-patches
"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> This patch correct bug, when localized day or month names was incorectly
> trnasformed to lower or upper string.

I really dislike the API you've chosen for upper_str/lower_str ---
overwriting the input on the assumption that it's long enough is a
buffer overrun bug waiting to happen, because (at least in utf8)
changing case doesn't preserve the byte length of the string.
Please make them return a freshly palloc'd string instead.

            regards, tom lane

pgsql-patches by date:

Previous
From: Tom Lane
Date:
Subject: Re: [pgsql-patches] Phantom Command IDs, updated patch
Next
From: Alvaro Herrera
Date:
Subject: Re: [pgsql-patches] [GENERAL] Corrupt database? 8.1/FreeBSD6.0