Re: TM formating patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: TM formating patch
Date
Msg-id 200702082034.l18KY2b01846@momjian.us
Whole thread Raw
In response to Re: TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
List pgsql-patches
Pavel Stehule wrote:
>
> >Patch applied.  Thanks.
> >
> >I have not backpatched it to 8.2.X because I am unclear of the risk
> >involved.  Suggestions?
>
> It's bug in 8.2. I don't know about any risks for 8.2

OK, I have backpatched it to 8.2.X.

---------------------------------------------------------------------------


>
> Pavel
>
> >
> >---------------------------------------------------------------------------
> >
> >
> >Pavel Stehule wrote:
> > > >"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> > > > > This patch correct bug, when localized day or month names was
> >incorectly
> > > > > trnasformed to lower or upper string.
> > > >
> > > >I really dislike the API you've chosen for upper_str/lower_str ---
> > > >overwriting the input on the assumption that it's long enough is a
> > > >buffer overrun bug waiting to happen, because (at least in utf8)
> > > >changing case doesn't preserve the byte length of the string.
> > > >Please make them return a freshly palloc'd string instead.
> > > >
> > > >            regards, tom lane
> > >
> > > I correct it, and test it for czech latin2 and utf8 case.
> > >
> > > Regards
> > > Pavel Stehule
> > >
> > > _________________________________________________________________
> > > Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/
> >
> >[ Attachment, skipping... ]
> >
> > >
> > > ---------------------------(end of broadcast)---------------------------
> > > TIP 3: Have you checked our extensive FAQ?
> > >
> > >                http://www.postgresql.org/docs/faq
> >
> >--
> >   Bruce Momjian  <bruce@momjian.us>          http://momjian.us
> >   EnterpriseDB                               http://www.enterprisedb.com
> >
> >   + If your life is a hard drive, Christ can be your backup. +
>
> _________________________________________________________________
> Emotikony a pozadi programu MSN Messenger ozivi vasi konverzaci.
> http://messenger.msn.cz/

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: patch for contrib/xml2
Next
From: Magnus Hagander
Date:
Subject: Re: Feature: POSIX Shared memory support