Re: TM formating patch - Mailing list pgsql-patches

From Bruce Momjian
Subject Re: TM formating patch
Date
Msg-id 200702081836.l18IaOu07836@momjian.us
Whole thread Raw
In response to Re: TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
Responses Re: TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
List pgsql-patches
Patch applied.  Thanks.

I have not backpatched it to 8.2.X because I am unclear of the risk
involved.  Suggestions?

---------------------------------------------------------------------------


Pavel Stehule wrote:
> >"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> > > This patch correct bug, when localized day or month names was incorectly
> > > trnasformed to lower or upper string.
> >
> >I really dislike the API you've chosen for upper_str/lower_str ---
> >overwriting the input on the assumption that it's long enough is a
> >buffer overrun bug waiting to happen, because (at least in utf8)
> >changing case doesn't preserve the byte length of the string.
> >Please make them return a freshly palloc'd string instead.
> >
> >            regards, tom lane
>
> I correct it, and test it for czech latin2 and utf8 case.
>
> Regards
> Pavel Stehule
>
> _________________________________________________________________
> Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
>
>                http://www.postgresql.org/docs/faq

--
  Bruce Momjian  <bruce@momjian.us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

pgsql-patches by date:

Previous
From: Bruce Momjian
Date:
Subject: Re: [pgsql-patches] Fixed shared_preload_libraries on Win32
Next
From: Bruce Momjian
Date:
Subject: Re: patch for contrib/xml2