Re: TM formating patch - Mailing list pgsql-patches

From Pavel Stehule
Subject Re: TM formating patch
Date
Msg-id BAY114-F169CD3857D9FA46937FC0FF9980@phx.gbl
Whole thread Raw
In response to TM formating patch  ("Pavel Stehule" <pavel.stehule@hotmail.com>)
Responses Re: TM formating patch
Re: TM formating patch
List pgsql-patches
>"Pavel Stehule" <pavel.stehule@hotmail.com> writes:
> > This patch correct bug, when localized day or month names was incorectly
> > trnasformed to lower or upper string.
>
>I really dislike the API you've chosen for upper_str/lower_str ---
>overwriting the input on the assumption that it's long enough is a
>buffer overrun bug waiting to happen, because (at least in utf8)
>changing case doesn't preserve the byte length of the string.
>Please make them return a freshly palloc'd string instead.
>
>            regards, tom lane

I correct it, and test it for czech latin2 and utf8 case.

Regards
Pavel Stehule

_________________________________________________________________
Chcete sdilet sve obrazky a hudbu s prateli? http://messenger.msn.cz/

Attachment

pgsql-patches by date:

Previous
From: Alvaro Herrera
Date:
Subject: Re: [pgsql-patches] Phantom Command IDs, updated patch
Next
From: Tom Lane
Date:
Subject: Re: [pgsql-patches] Phantom Command IDs, updated patch