Thread: pg_dump fails on domain constraint comments

Hello Alvaro,

It looks like pg_dump emits incorrect text for domain constraint comments:

Assuming the following structure,

CREATE DOMAIN "dom" AS integer
        CONSTRAINT "dom_constraint" CHECK ((VALUE > 10));

COMMENT ON CONSTRAINT "dom_constraint" ON DOMAIN "dom" IS 'domain constraint comment'

pg_dump will dump the COMMENT as follow:

COMMENT ON CONSTRAINT "dom_constraint" ON DOMAIN """dom""" IS 'domain constraint comment'

Note the double-quoting issue of the domain name.

Attached patch fixes that.

                                    Elvis

On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans@gmail.com> wrote:
> It looks like pg_dump emits incorrect text for domain constraint comments:
>
> Assuming the following structure,

Nice catch! qtypname already has fmtId applied to it, so quotes are
applied twice to it in this case. I am adding an entry in the next CF
with patch marked as ready for committer so as this does not fail into
oblivion. A backpatch would be welcome as well.

Here is the patch entry:
https://commitfest.postgresql.org/9/481/
I could not add your name as an author as you visibly do not have a
community account. That's no big deal, I am just mentioning it here to
avoid confusion.
-- 
Michael

Michael Paquier wrote:
> On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans@gmail.com> wrote:
> > It looks like pg_dump emits incorrect text for domain constraint comments:
> >
> > Assuming the following structure,
> 
> Nice catch! qtypname already has fmtId applied to it, so quotes are
> applied twice to it in this case. I am adding an entry in the next CF
> with patch marked as ready for committer so as this does not fail into
> oblivion. A backpatch would be welcome as well.

Yeah, evidently I didn't test that part.  Thanks Elvis, applied and
backpatched to 9.5.

... Oh, I just noticed you requested this feature back in 2013,
https://www.postgresql.org/message-id/5310157.yWWCtg2qIU%40klinga.prans.org
I hope that it's doing what you wanted!

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

On January 22, 2016 08:09:36 PM Alvaro Herrera wrote:
> Michael Paquier wrote:
> > On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans@gmail.com> 
wrote:
> > > It looks like pg_dump emits incorrect text for domain constraint
> > > comments:
> > > 
> > > Assuming the following structure,
> > 
> > Nice catch! qtypname already has fmtId applied to it, so quotes are
> > applied twice to it in this case. I am adding an entry in the next CF
> > with patch marked as ready for committer so as this does not fail into
> > oblivion. A backpatch would be welcome as well.
> 
> Yeah, evidently I didn't test that part.  Thanks Elvis, applied and
> backpatched to 9.5.
> 
> ... Oh, I just noticed you requested this feature back in 2013,
> https://www.postgresql.org/message-id/5310157.yWWCtg2qIU%40klinga.prans.org
> I hope that it's doing what you wanted!

Yes, works like a charm!  Thanks for implementing this.

                                   Elvis