Re: pg_dump fails on domain constraint comments - Mailing list pgsql-hackers

From Elvis Pranskevichus
Subject Re: pg_dump fails on domain constraint comments
Date
Msg-id 3307594.KDmpRk6pVS@klinga.prans.org
Whole thread Raw
In response to Re: pg_dump fails on domain constraint comments  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On January 22, 2016 08:09:36 PM Alvaro Herrera wrote:
> Michael Paquier wrote:
> > On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans@gmail.com> 
wrote:
> > > It looks like pg_dump emits incorrect text for domain constraint
> > > comments:
> > > 
> > > Assuming the following structure,
> > 
> > Nice catch! qtypname already has fmtId applied to it, so quotes are
> > applied twice to it in this case. I am adding an entry in the next CF
> > with patch marked as ready for committer so as this does not fail into
> > oblivion. A backpatch would be welcome as well.
> 
> Yeah, evidently I didn't test that part.  Thanks Elvis, applied and
> backpatched to 9.5.
> 
> ... Oh, I just noticed you requested this feature back in 2013,
> https://www.postgresql.org/message-id/5310157.yWWCtg2qIU%40klinga.prans.org
> I hope that it's doing what you wanted!

Yes, works like a charm!  Thanks for implementing this.

                                   Elvis



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Proposal: Trigonometric functions in degrees
Next
From: Jeff Janes
Date:
Subject: Re: Combining Aggregates