Re: pg_dump fails on domain constraint comments - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: pg_dump fails on domain constraint comments
Date
Msg-id 20160122230936.GA461928@alvherre.pgsql
Whole thread Raw
In response to Re: pg_dump fails on domain constraint comments  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: pg_dump fails on domain constraint comments  (Elvis Pranskevichus <elprans@gmail.com>)
List pgsql-hackers
Michael Paquier wrote:
> On Tue, Jan 12, 2016 at 7:56 AM, Elvis Pranskevichus <elprans@gmail.com> wrote:
> > It looks like pg_dump emits incorrect text for domain constraint comments:
> >
> > Assuming the following structure,
> 
> Nice catch! qtypname already has fmtId applied to it, so quotes are
> applied twice to it in this case. I am adding an entry in the next CF
> with patch marked as ready for committer so as this does not fail into
> oblivion. A backpatch would be welcome as well.

Yeah, evidently I didn't test that part.  Thanks Elvis, applied and
backpatched to 9.5.

... Oh, I just noticed you requested this feature back in 2013,
https://www.postgresql.org/message-id/5310157.yWWCtg2qIU%40klinga.prans.org
I hope that it's doing what you wanted!

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Petr Jelinek
Date:
Subject: Re: Proposal: Generic WAL logical messages
Next
From: Tom Lane
Date:
Subject: Re: Removing Functionally Dependent GROUP BY Columns