Postgres Pro
Downloads
Home   >   mailing lists

pg_dump fails on domain constraint comments - Mailing list pgsql-hackers

From Elvis Pranskevichus
Subject pg_dump fails on domain constraint comments
Date
Msg-id 3789929.ZsF6ME7o6i@klinga.prans.org
Whole thread Raw
Responses Re: pg_dump fails on domain constraint comments  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Tree view 
Hello Alvaro,

It looks like pg_dump emits incorrect text for domain constraint comments:

Assuming the following structure,

CREATE DOMAIN "dom" AS integer
        CONSTRAINT "dom_constraint" CHECK ((VALUE > 10));

COMMENT ON CONSTRAINT "dom_constraint" ON DOMAIN "dom" IS 'domain constraint comment'

pg_dump will dump the COMMENT as follow:

COMMENT ON CONSTRAINT "dom_constraint" ON DOMAIN """dom""" IS 'domain constraint comment'

Note the double-quoting issue of the domain name.

Attached patch fixes that.

                                    Elvis
Attachment

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Speedup twophase transactions
Next
From: Stas Kelvich
Date:
Subject: Re: Speedup twophase transactions