Thread: Minor comment improvement to create_foreignscan_plan
Hi, Here is a small patch to update an comment in create_foreignscan_plan; add fdw_recheck_quals to the list of expressions that need the replace_nestloop_params processing. I should have updated the comment when I proposed the patch for the fdw_recheck_quals. Best regards, Etsuro Fujita
Attachment
On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote: > Here is a small patch to update an comment in create_foreignscan_plan; > add fdw_recheck_quals to the list of expressions that need the > replace_nestloop_params processing. I should have updated the comment > when I proposed the patch for the fdw_recheck_quals. OK, not a big deal, but thanks. Committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 2015/11/10 3:53, Robert Haas wrote: > On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita > <fujita.etsuro@lab.ntt.co.jp> wrote: >> Here is a small patch to update an comment in create_foreignscan_plan; >> add fdw_recheck_quals to the list of expressions that need the >> replace_nestloop_params processing. I should have updated the comment >> when I proposed the patch for the fdw_recheck_quals. > OK, not a big deal, but thanks. Committed. Thanks! Best regards, Etsuro Fujita
On 2015/11/12 19:02, Etsuro Fujita wrote: > On 2015/11/10 3:53, Robert Haas wrote: >> On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita >> <fujita.etsuro@lab.ntt.co.jp> wrote: >>> Here is a small patch to update an comment in create_foreignscan_plan; >>> add fdw_recheck_quals to the list of expressions that need the >>> replace_nestloop_params processing. I should have updated the comment >>> when I proposed the patch for the fdw_recheck_quals. >> OK, not a big deal, but thanks. Committed. > Thanks! Oops, I've found another one. I think we should update a comment in postgresGetForeignPlan, too; add remote filtering expressions to the list of information needed to create a ForeignScan node. Best regards, Etsuro Fujita
Attachment
On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote: > Oops, I've found another one. I think we should update a comment in > postgresGetForeignPlan, too; add remote filtering expressions to the list of > information needed to create a ForeignScan node. Instead of saying "remote/local", how about saying "remote and local" or just leaving it out altogether as in the attached? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Attachment
On 2015/11/18 2:57, Robert Haas wrote: > On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita > <fujita.etsuro@lab.ntt.co.jp> wrote: >> Oops, I've found another one. I think we should update a comment in >> postgresGetForeignPlan, too; add remote filtering expressions to the list of >> information needed to create a ForeignScan node. > Instead of saying "remote/local", how about saying "remote and local" > or just leaving it out altogether as in the attached? +1 for your patch. Best regards, Etsuro Fujita
On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp> wrote: > On 2015/11/18 2:57, Robert Haas wrote: >> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita >> <fujita.etsuro@lab.ntt.co.jp> wrote: >>> >>> Oops, I've found another one. I think we should update a comment in >>> postgresGetForeignPlan, too; add remote filtering expressions to the list >>> of >>> information needed to create a ForeignScan node. > >> Instead of saying "remote/local", how about saying "remote and local" >> or just leaving it out altogether as in the attached? > > +1 for your patch. OK, committed. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 2015/11/19 5:29, Robert Haas wrote: > On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita > <fujita.etsuro@lab.ntt.co.jp> wrote: >> On 2015/11/18 2:57, Robert Haas wrote: >>> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita >>> <fujita.etsuro@lab.ntt.co.jp> wrote: >>>> Oops, I've found another one. I think we should update a comment in >>>> postgresGetForeignPlan, too; add remote filtering expressions to the list >>>> of >>>> information needed to create a ForeignScan node. >>> Instead of saying "remote/local", how about saying "remote and local" >>> or just leaving it out altogether as in the attached? >> +1 for your patch. > OK, committed. Thanks! Best regards, Etsuro Fujita