Re: Minor comment improvement to create_foreignscan_plan - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Minor comment improvement to create_foreignscan_plan
Date
Msg-id 564D425B.7000703@lab.ntt.co.jp
Whole thread Raw
In response to Re: Minor comment improvement to create_foreignscan_plan  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2015/11/19 5:29, Robert Haas wrote:
> On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> On 2015/11/18 2:57, Robert Haas wrote:
>>> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
>>> <fujita.etsuro@lab.ntt.co.jp> wrote:
>>>> Oops, I've found another one.  I think we should update a comment in
>>>> postgresGetForeignPlan, too; add remote filtering expressions to the list
>>>> of
>>>> information needed to create a ForeignScan node.

>>> Instead of saying "remote/local", how about saying "remote and local"
>>> or just leaving it out altogether as in the attached?

>> +1 for your patch.

> OK, committed.

Thanks!

Best regards,
Etsuro Fujita




pgsql-hackers by date:

Previous
From: Marko Tiikkaja
Date:
Subject: Add numeric_trim(numeric)
Next
From: Robert Haas
Date:
Subject: Re: Foreign join pushdown vs EvalPlanQual