Re: Minor comment improvement to create_foreignscan_plan - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Minor comment improvement to create_foreignscan_plan
Date
Msg-id CA+TgmoZ03YMn_yDz0782TvDVvhMUB4D9OXXVngbzKff9Xm7GmQ@mail.gmail.com
Whole thread Raw
In response to Re: Minor comment improvement to create_foreignscan_plan  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Minor comment improvement to create_foreignscan_plan  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
On Tue, Nov 17, 2015 at 9:29 PM, Etsuro Fujita
<fujita.etsuro@lab.ntt.co.jp> wrote:
> On 2015/11/18 2:57, Robert Haas wrote:
>> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
>> <fujita.etsuro@lab.ntt.co.jp> wrote:
>>>
>>> Oops, I've found another one.  I think we should update a comment in
>>> postgresGetForeignPlan, too; add remote filtering expressions to the list
>>> of
>>> information needed to create a ForeignScan node.
>
>> Instead of saying "remote/local", how about saying "remote and local"
>> or just leaving it out altogether as in the attached?
>
> +1 for your patch.

OK, committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: proposal: multiple psql option -c
Next
From: Jeff Janes
Date:
Subject: Re: Freeze avoidance of very large table.