Re: Minor comment improvement to create_foreignscan_plan - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Minor comment improvement to create_foreignscan_plan
Date
Msg-id 564BE270.6060809@lab.ntt.co.jp
Whole thread Raw
In response to Re: Minor comment improvement to create_foreignscan_plan  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: Minor comment improvement to create_foreignscan_plan  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2015/11/18 2:57, Robert Haas wrote:
> On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita
> <fujita.etsuro@lab.ntt.co.jp> wrote:
>> Oops, I've found another one.  I think we should update a comment in
>> postgresGetForeignPlan, too; add remote filtering expressions to the list of
>> information needed to create a ForeignScan node.

> Instead of saying "remote/local", how about saying "remote and local"
> or just leaving it out altogether as in the attached?

+1 for your patch.

Best regards,
Etsuro Fujita




pgsql-hackers by date:

Previous
From: Kouhei Kaigai
Date:
Subject: Re: Foreign join pushdown vs EvalPlanQual
Next
From: Etsuro Fujita
Date:
Subject: Re: Foreign join pushdown vs EvalPlanQual