Re: Minor comment improvement to create_foreignscan_plan - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Re: Minor comment improvement to create_foreignscan_plan
Date
Msg-id 56493EA0.2000101@lab.ntt.co.jp
Whole thread Raw
In response to Re: Minor comment improvement to create_foreignscan_plan  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Minor comment improvement to create_foreignscan_plan  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On 2015/11/12 19:02, Etsuro Fujita wrote:
> On 2015/11/10 3:53, Robert Haas wrote:
>> On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita
>> <fujita.etsuro@lab.ntt.co.jp> wrote:
>>> Here is a small patch to update an comment in create_foreignscan_plan;
>>> add fdw_recheck_quals to the list of expressions that need the
>>> replace_nestloop_params processing.  I should have updated the comment
>>> when I proposed the patch for the fdw_recheck_quals.

>> OK, not a big deal, but thanks.  Committed.

> Thanks!

Oops, I've found another one.  I think we should update a comment in
postgresGetForeignPlan, too; add remote filtering expressions to the
list of information needed to create a ForeignScan node.

Best regards,
Etsuro Fujita

Attachment

pgsql-hackers by date:

Previous
From: Craig Ringer
Date:
Subject: Re: pglogical_output - a general purpose logical decoding output plugin
Next
From: Michael Paquier
Date:
Subject: Re: Proposing COPY .. WITH PERMISSIVE