Thread: [9.4 CF 1] And then there were 5
... well, 11 actually. We are down to 3 patches needing review, 2 waiting on author, and 6 waiting on commit. Whatever folks can do to close out this commitfest is very welcome! -- Josh Berkus PostgreSQL Experts Inc. http://pgexperts.com
After pushes from a few people, the remaining submissions are now
waiting for commit. I updated each of those to have the latest info in
the CF app, and tried to identify what committers have already looked at
them.
Access to calls stack from GET DIAGNOSTICS statement: ?
Add more regression tests mostly for ALTER OPERATOR FAMILY .. ADD/DROP: ? Robert Haas gave a quick review last week
that'sgenerated an
update since. But that looks it was just a quick scan for issues.
Remove unused targets from plan: Alvaro? (He reviewed it already)
SQL Command to edit postgresql.conf ("ALTER SYSTEM" patch): Alvaro
volunteered to look at this if no one else gets to it first.
UNNEST() (and other functions) WITH ORDINALITY: Greg Stark
--
Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD
PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
Greg Smith <greg@2ndQuadrant.com> writes:
> Remove unused targets from plan: Alvaro? (He reviewed it already)
Really I should do that one, but it seems like all my available cycles
have been going into bug fixing lately :-(
regards, tom lane
Tom Lane wrote: > Greg Smith <greg@2ndQuadrant.com> writes: > > Remove unused targets from plan: Alvaro? (He reviewed it already) > > Really I should do that one, but it seems like all my available cycles > have been going into bug fixing lately :-( Yeah, I only did a first pass over that patch and was expecting you would pick it up. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
On 7/22/13 10:48 PM, Tom Lane wrote: > Greg Smith <greg@2ndQuadrant.com> writes: >> Remove unused targets from plan: Alvaro? (He reviewed it already) > > Really I should do that one, but it seems like all my available cycles > have been going into bug fixing lately :-( I just put you down as the committer on it, given Alvaro waved that way too. A further look at recently ALTER OPERATOR FAMILY changes shows that Robert has been working on those quite a bit. I'm putting him down as the committer on this last one. If the CF drags on a bit due to committer time being spent on bugs, given the date here I think that's OK. I would put next week as a loose target for finishing these off. I worry a lot less about committers keeping to their schedules than when there are 50 regular contributors still moving around. That leaves only 1 patch where I have no idea who will commit it: access to calls stack from GET DIAGNOSTICS statement -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
Greg,
First, thanks for helping out with the CF.
* Greg Smith (greg@2ndQuadrant.com) wrote:
> That leaves only 1 patch where I have no idea who will commit it:
>
> access to calls stack from GET DIAGNOSTICS statement
I'll take a look at this.
Thanks again,
Stephen
On Tue, Jul 23, 2013 at 12:04 AM, Greg Smith <greg@2ndquadrant.com> wrote: > A further look at recently ALTER OPERATOR FAMILY changes shows that Robert > has been working on those quite a bit. I'm putting him down as the > committer on this last one. I missed that one, now committed. But just BTW, you kind of messed up that CommitFest entry. The link you added as a new version of the patch was actually to a different patch from the same flock. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
On 7/23/13 9:06 AM, Robert Haas wrote: > But just BTW, you kind of messed up that CommitFest entry. The link you added as a new version of the > patch was actually to a different patch from the same flock. Fixed now, since I find myself looking back through history on submissions often enough to care about it being right. My eyes were starting to glaze over by the end of staring at this "flock". -- Greg Smith 2ndQuadrant US greg@2ndQuadrant.com Baltimore, MD PostgreSQL Training, Services, and 24x7 Support www.2ndQuadrant.com
On Tue, Jul 23, 2013 at 9:22 AM, Greg Smith <greg@2ndquadrant.com> wrote: > On 7/23/13 9:06 AM, Robert Haas wrote: >> >> But just BTW, you kind of messed up that CommitFest entry. The link you >> added as a new version of the >> patch was actually to a different patch from the same flock. > > Fixed now, since I find myself looking back through history on submissions > often enough to care about it being right. My eyes were starting to glaze > over by the end of staring at this "flock". Cool. I'm pretty sure that's the correct collective noun for patches. Right? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company