Re: Non-reserved replication slots and slot advancing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Non-reserved replication slots and slot advancing
Date
Msg-id 20180709064833.GB30202@paquier.xyz
Whole thread Raw
In response to Re: Non-reserved replication slots and slot advancing  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Non-reserved replication slots and slot advancing  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Re: Non-reserved replication slots and slot advancing  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
On Mon, Jul 09, 2018 at 03:13:04PM +0900, Kyotaro HORIGUCHI wrote:
> Looking the attached patch, I noticed that both "WAL" and "wal"
> are used in similar ERROR messages. Grepping the source tree
> showed me that it is always in upper case letters except in the
> case it is a part of other words like variable/column/function
> names or "walsender". This is the same with the word "lsn".

Thanks for the lookup.

I see.  Indeed, let's fix at the same time the error message close by.
xlog.c uses "WAL location (LSN)" for the same thing, so I am sticking
with that as per the attached.  I'll go commit that if there are no
objections.  If you see any others which you would like to fix, please
feel free to send a patch.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Markus Wanner
Date:
Subject: Re: How can we submit code patches that implement our (pending)patents?
Next
From: Michael Paquier
Date:
Subject: Re: Possible bug in logical replication.