Re: Possible bug in logical replication. - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Possible bug in logical replication.
Date
Msg-id 20180709070200.GC30202@paquier.xyz
Whole thread Raw
In response to Re: Possible bug in logical replication.  (Arseny Sher <a.sher@postgrespro.ru>)
Responses Re: Possible bug in logical replication.  (Arseny Sher <a.sher@postgrespro.ru>)
List pgsql-hackers
On Tue, Jul 03, 2018 at 09:16:42AM +0300, Arseny Sher wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Thu, Jun 21, 2018 at 07:31:20PM +0900, Michael Paquier wrote:
>>> Could it be possible to get a patch from all the feedback and exchange
>>> gathered here?  Petr, I think that it would not hurt if you use the set
>>> of words and comments you think is most adapted as the primary author of
>>> the feature.
>>
>> I have seen no patch, so attached is one to finally close the loop and
>> this open item, which includes both my suggestions and what Arseny has
>> mentioned based on the latest emails exchanged.  Any objections to that?
>
> I'm practically happy with this.
>
>>  * while confirmed_lsn is used as base point for the decoding context.
>
> This line is excessive as now we have comment below saying it doesn't
> matter.

Okay, let's do as you suggest then.  Do you find the attached adapted?
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Non-reserved replication slots and slot advancing
Next
From: David Rowley
Date:
Subject: Re: Generating partitioning tuple conversion maps faster