Thread: Patch for SonarQube UI fixes.

Hi,

The patch looks good to me.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

The patch looks good to me.

I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

As per my earlier comment, the dashboard.js fix is still failing.

On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

The patch looks good to me.

I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

As per my earlier comment, the dashboard.js fix is still failing.

But assigning the return value is not a solution. Replace map with forEach so that it doesn't expect a return value at all (as there is none).

On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

The patch looks good to me.

I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

As per my earlier comment, the dashboard.js fix is still failing.

But assigning the return value is not a solution. Replace map with forEach so that it doesn't expect a return value at all (as there is none).

I think this is not a problem of map but the combination, Object.keys.map which expects return value and that is the reason I previously pointed out that *this is not the accurate fix*.

 

On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

The patch looks good to me.

I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

On Tue, Jun 16, 2020 at 8:57 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Tue, Jun 16, 2020 at 8:46 AM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

On Tue, Jun 16, 2020 at 8:22 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

As per my earlier comment, the dashboard.js fix is still failing.

But assigning the return value is not a solution. Replace map with forEach so that it doesn't expect a return value at all (as there is none).

I think this is not a problem of map but the combination, Object.keys.map which expects return value and that is the reason I previously pointed out that *this is not the accurate fix*.

That's what I said - Replace map with forEach so that it doesn't expect a return value at all (as there is none) :)

 

On Mon, Jun 15, 2020 at 5:16 PM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:

Thanks, patch applied.

On Mon, Jun 15, 2020 at 4:49 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:

Hi,

The patch looks good to me.

I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:

Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.

PFA patch.

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks & Regards

Akshay Joshi

Sr. Software Architect

EnterpriseDB Software India Private Limited

Mobile: +91 976-788-8246

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"

--

Thanks and Regards,

Aditya Toshniwal

pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune

"Don't Complain about Heat, Plant a TREE"