Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube UI fixes. - Mailing list pgadmin-hackers

From Aditya Toshniwal
Subject Re: Patch for SonarQube UI fixes.
Date
Msg-id CAM9w-_=0Z8=f0=aycKR7CghdU99-gY_V9HVu-uTUPtS7DHb5og@mail.gmail.com
Whole thread Raw
In response to Re: Patch for SonarQube UI fixes.  (Khushboo Vashi <khushboo.vashi@enterprisedb.com>)
Responses Re: Patch for SonarQube UI fixes.
List pgadmin-hackers
Tree view
Hi,

On Mon, Jun 15, 2020 at 4:45 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

The patch looks good to me.
I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.
It's the map function which requires the return. Not necessary to assign the return value.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.
PFA patch.


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Khushboo Vashi
Date:
Subject: Re: Patch for SonarQube UI fixes.
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Ensure that pgadmin should be able to connect to the