Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch for SonarQube UI fixes. - Mailing list pgadmin-hackers

From Khushboo Vashi
Subject Re: Patch for SonarQube UI fixes.
Date
Msg-id CAFOhELfYZ0DHEL81rH-hpgmQgcwxb5wt7=CtMgpN-qV8_Pdi0w@mail.gmail.com
Whole thread Raw
In response to Re: Patch for SonarQube UI fixes.  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
Responses Re: Patch for SonarQube UI fixes.  (Aditya Toshniwal <aditya.toshniwal@enterprisedb.com>)
List pgadmin-hackers
Tree view

On Mon, Jun 15, 2020 at 4:42 PM Aditya Toshniwal <aditya.toshniwal@enterprisedb.com> wrote:
Hi,

The patch looks good to me.
I think the dashboard.js fix is not accurate as when you return something you have to assign that value to any variable.

On Mon, Jun 15, 2020 at 4:22 PM Nikhil Mohite <nikhil.mohite@enterprisedb.com> wrote:
Hi Team,

I have fixed some UI related  issues of SonarQube scan.
Mainly fixes are related to removing duplicate properties in css class and few js standard syntax fixes.
PFA patch.


--
Thanks and Regards,
Aditya Toshniwal
pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: [pgAdmin][patch] Runtime fixes reported by SonarQube
Next
From: Aditya Toshniwal
Date:
Subject: Re: Patch for SonarQube UI fixes.