Postgres Pro
Downloads
Home   >   mailing lists

Thread: Patch to remove Python 2.7 support in the macOS Appbundle

Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Khushboo Vashi
Date:
Hi Dave,

As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions?

Thanks,
Khushboo

On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:


On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions?

Yes, for now. We're not actively removing support for old PostgreSQL versions, just not testing them.
 

Thanks,
Khushboo

On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Khushboo Vashi
Date:


On Mon, Apr 27, 2020 at 3:23 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions?

Yes, for now. We're not actively removing support for old PostgreSQL versions, just not testing them.
 
Yes, we are not removing it but do we need to update SQL templates for older versions when we do update for the supported versions in case of any bug fixes?

Thanks,
Khushboo

On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:


On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Mon, Apr 27, 2020 at 3:23 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions?

Yes, for now. We're not actively removing support for old PostgreSQL versions, just not testing them.
 
Yes, we are not removing it but do we need to update SQL templates for older versions when we do update for the supported versions in case of any bug fixes?

If a bug is reported and is easily fixable, I don't see why not.
 

Thanks,
Khushboo

On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Khushboo Vashi
Date:


On Mon, Apr 27, 2020 at 3:28 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 10:57 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:


On Mon, Apr 27, 2020 at 3:23 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 10:52 AM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi Dave,

As we support PostgreSQL >=9.5, do we need to maintain SQL templates for older versions?

Yes, for now. We're not actively removing support for old PostgreSQL versions, just not testing them.
 
Yes, we are not removing it but do we need to update SQL templates for older versions when we do update for the supported versions in case of any bug fixes?

If a bug is reported and is easily fixable, I don't see why not.
 
Sure but not every time it's easily fixable.:)

Team,
I am reviewing this patch.

Thanks,
Khushboo


Thanks,
Khushboo

On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Khushboo Vashi
Date:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Thanks,
Khushboo


On Mon, Apr 27, 2020 at 3:16 PM Dave Page <dpage@pgadmin.org> wrote:
The attached patch removes support for Python 2.7 in general from the macOS appbundle build, thus also removing special handling for use of the system Python installation.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:
Akshay, are you happy with this patch?

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Akshay Joshi
Date:
Hi Dave

On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay, are you happy with this patch?

   The patch is not applied to the latest code. 

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:
Here's a rebased version.

On Mon, May 4, 2020 at 7:33 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay, are you happy with this patch?

   The patch is not applied to the latest code. 

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Akshay Joshi
Date:
Hi Dave

Patch looks good to me except the below line gets commented by mistake (if i am not wrong)
# ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo complete-bundle.sh failed; exit 1; }

On Mon, May 4, 2020 at 3:02 PM Dave Page <dpage@pgadmin.org> wrote:
Here's a rebased version.

On Mon, May 4, 2020 at 7:33 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay, are you happy with this patch?

   The patch is not applied to the latest code. 

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

Re: Patch to remove Python 2.7 support in the macOS Appbundle

From
Dave Page
Date:
Thanks, applied.

On Mon, May 4, 2020 at 10:59 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

Patch looks good to me except the below line gets commented by mistake (if i am not wrong)
# ./complete-bundle.sh "${BUILDROOT}/${APP_BUNDLE_NAME}" || { echo complete-bundle.sh failed; exit 1; }

On Mon, May 4, 2020 at 3:02 PM Dave Page <dpage@pgadmin.org> wrote:
Here's a rebased version.

On Mon, May 4, 2020 at 7:33 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay, are you happy with this patch?

   The patch is not applied to the latest code. 

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company