Re: Patch to remove Python 2.7 support in the macOS Appbundle - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Patch to remove Python 2.7 support in the macOS Appbundle
Date
Msg-id CA+OCxox1WPNWbN3ikyq5ktfPHt0LU6LObeV=4rLv95G5vFRzXA@mail.gmail.com
Whole thread Raw
In response to Re: Patch to remove Python 2.7 support in the macOS Appbundle  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
Responses Re: Patch to remove Python 2.7 support in the macOS Appbundle  (Akshay Joshi <akshay.joshi@enterprisedb.com>)
List pgadmin-hackers
Here's a rebased version.

On Mon, May 4, 2020 at 7:33 AM Akshay Joshi <akshay.joshi@enterprisedb.com> wrote:
Hi Dave

On Fri, May 1, 2020 at 5:21 PM Dave Page <dpage@pgadmin.org> wrote:
Akshay, are you happy with this patch?

   The patch is not applied to the latest code. 

On Mon, Apr 27, 2020 at 3:30 PM Dave Page <dpage@pgadmin.org> wrote:


On Mon, Apr 27, 2020 at 3:28 PM Khushboo Vashi <khushboo.vashi@enterprisedb.com> wrote:
Hi,

The code looks good to me. The package building was tested by Neel and we found that the venv was built with Python 3+ but the runtime was built against Python 2.7.
As per Dave, Neel may have not used a venv of the correct version as it is working fine on Dav'e system. So, we can commit the patch.

Yeah, that's not ideal, but the same problem exists today. I need to spend some time figuring out how to make that more robust. 

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Cleanup runtime qmake code
Next
From: Akshay Joshi
Date:
Subject: pgAdmin 4 commit: Raise an exception under Python < 3.4 for WSGI mode.