Postgres Pro
Downloads
Home   >   mailing lists

Thread: Fixes for pgAdmin4 messages

Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Hi,

Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of).

On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
01.11.2017 12:04, Dave Page wrote:
Hi,

Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of).
Sure, If you are going to accept all (or almost all) the changes, a single patch is better.

On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Hi

On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
01.11.2017 12:04, Dave Page wrote:
Hi,

Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of).
 Sure, If you are going to accept all (or almost all) the changes, a single patch is better.

I did - albeit with a couple of additional tweaks.
 

On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
We do, but it is a WIP: https://www.pgadmin.org/styleguide/. Unfortunately, we haven't got as far as message phrasing yet. If anyone wants to take a crack at it, that would be helpful.
 
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?
No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surprised :-). Seriously though, I think messages should lack emotion like that.

Thanks for the patch!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello Dave,
01.11.2017 16:05, Dave Page wrote:
Hi

On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin <exclusion@gmail.com> wrote:


I did - albeit with a couple of additional tweaks.
Thanks!
No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surprised :-). Seriously though, I think messages should lack emotion like that.
Then please consider applying the next patch (attached),


Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Hi

On Wed, Nov 1, 2017 at 2:13 PM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello Dave,
01.11.2017 16:05, Dave Page wrote:
Hi

On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin <exclusion@gmail.com> wrote:


I did - albeit with a couple of additional tweaks.
Thanks!
No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surprised :-). Seriously though, I think messages should lack emotion like that.
 Then please consider applying the next patch (attached),

Thanks - patch applied.
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Hi

Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling from tomorrow AM, and will have limited availability).

On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment

Re: Fixes for pgAdmin4 messages

From
Ashesh Vashi
Date:
Looks like - the patch has introduced syntax error in database.js.

On Nov 3, 2017 22:19, "Dave Page" <dpage@pgadmin.org> wrote:
Hi

Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling from tomorrow AM, and will have limited availability).

On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello,

04.11.2017 07:05, Ashesh Vashi wrote:
Looks like - the patch has introduced syntax error in database.js.

On Nov 3, 2017 22:19, "Dave Page" <dpage@pgadmin.org> wrote:
Hi

Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling from tomorrow AM, and will have limited availability).
Sorry, the error was caused by 'gettext' import missing in variable.js.
Please apply the fixed version.
On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
That looks like it - thanks, applied!

On Sat, Nov 4, 2017 at 2:25 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

04.11.2017 07:05, Ashesh Vashi wrote:
Looks like - the patch has introduced syntax error in database.js.

On Nov 3, 2017 22:19, "Dave Page" <dpage@pgadmin.org> wrote:
Hi

Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling from tomorrow AM, and will have limited availability).
 Sorry, the error was caused by 'gettext' import missing in variable.js.
Please apply the fixed version.
On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello,

05.11.2017 16:36, Dave Page wrote:
That looks like it - thanks, applied!
Thank you!

And another one.
(I've processed onText/offText instances, alertify.*  calls and depends.js)
Please look at it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Hi

I think you forgot to attach the patch.

Thanks, Dave

On Mon, Nov 6, 2017 at 9:00 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

05.11.2017 16:36, Dave Page wrote:
That looks like it - thanks, applied!
 Thank you!

And another one.
(I've processed onText/offText instances, alertify.*  calls and depends.js)
Please look at it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Re: Fixes for pgAdmin4 messages

From
Alexander Lakhin
Date:
Hello,

05.11.2017 16:36, Dave Page wrote:
That looks like it - thanks, applied!
Thank you!

And another one.
(I've processed onText/offText instances, alertify.*  calls and depends.js)
Please look at it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

Re: Fixes for pgAdmin4 messages

From
Dave Page
Date:
Thanks, applied with some wording tweaks.

On Mon, Nov 6, 2017 at 9:13 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

05.11.2017 16:36, Dave Page wrote:
That looks like it - thanks, applied!
 Thank you!

And another one.
(I've processed onText/offText instances, alertify.*  calls and depends.js)
 Please look at it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company