Re: Fixes for pgAdmin4 messages - Mailing list pgadmin-hackers

From Alexander Lakhin
Subject Re: Fixes for pgAdmin4 messages
Date
Msg-id 43ea326e-9189-2466-6072-8e1897ddfe15@gmail.com
Whole thread Raw
In response to Re: Fixes for pgAdmin4 messages  (Ashesh Vashi <ashesh.vashi@enterprisedb.com>)
Responses Re: Fixes for pgAdmin4 messages
List pgadmin-hackers
Hello,

04.11.2017 07:05, Ashesh Vashi wrote:
Looks like - the patch has introduced syntax error in database.js.

On Nov 3, 2017 22:19, "Dave Page" <dpage@pgadmin.org> wrote:
Hi

Unfortunately I've had to revert this. It was causing the treeview to render incorrectly (see the attached screenshot).

Can you take a look please? I've CC'd Ashesh as he knows that area of the code far better than I do and may be able to spot the issue much more quickly (plus I'm travelling from tomorrow AM, and will have limited availability).
Sorry, the error was caused by 'gettext' import missing in variable.js.
Please apply the fixed version.
On Fri, Nov 3, 2017 at 1:14 PM, Dave Page <dpage@pgadmin.org> wrote:
Thanks, patch applied.

On Fri, Nov 3, 2017 at 10:52 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,
I have another patch for the better localization of pgAdmin4.
Please consider applying it.

------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgadmin-hackers by date:

Previous
From: Ashesh Vashi
Date:
Subject: Re: Fixes for pgAdmin4 messages
Next
From: "Begina Felicysym"
Date:
Subject: Polish translation for current version of pgadmin4