Re: Fixes for pgAdmin4 messages - Mailing list pgadmin-hackers

From Dave Page
Subject Re: Fixes for pgAdmin4 messages
Date
Msg-id CA+OCxow6yhfRPodpA5ZCEoqUBe9j-eh9agt291FG-TLKzJtadA@mail.gmail.com
Whole thread Raw
In response to Re: Fixes for pgAdmin4 messages  (Alexander Lakhin <exclusion@gmail.com>)
Responses Re: Fixes for pgAdmin4 messages
List pgadmin-hackers
Hi

On Wed, Nov 1, 2017 at 9:12 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
01.11.2017 12:04, Dave Page wrote:
Hi,

Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of).
Sure, If you are going to accept all (or almost all) the changes, a single patch is better.

I did - albeit with a couple of additional tweaks.
 

On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
We do, but it is a WIP: https://www.pgadmin.org/styleguide/. Unfortunately, we haven't got as far as message phrasing yet. If anyone wants to take a crack at it, that would be helpful.
 
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?
No, I don't think there are reasons to have exclamation marks. pgAdmin shouldn't ever be surprised :-). Seriously though, I think messages should lack emotion like that.

Thanks for the patch!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Message catalog update. Current stats look like:
Next
From: Dave Page
Date:
Subject: Re: [pgAdmin4][Patch]: To handle long numbers for Rows (estimated)field in Table's properties