Re: Fixes for pgAdmin4 messages - Mailing list pgadmin-hackers

From Alexander Lakhin
Subject Re: Fixes for pgAdmin4 messages
Date
Msg-id cb849765-ceac-b90c-a774-bf72f7ab5c7e@gmail.com
Whole thread Raw
In response to Re: Fixes for pgAdmin4 messages  (Dave Page <dpage@pgadmin.org>)
Responses Re: Fixes for pgAdmin4 messages  (Dave Page <dpage@pgadmin.org>)
List pgadmin-hackers
01.11.2017 12:04, Dave Page wrote:
Hi,

Can you re-sent this as a single patch please? Working through 23 will take me significantly more time (which I have little of).
Sure, If you are going to accept all (or almost all) the changes, a single patch is better.

On Wed, Nov 1, 2017 at 7:33 AM, Alexander Lakhin <exclusion@gmail.com> wrote:
Hello,

While translating the messages, I encountered some English messages, that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like: https://www.postgresql.org/docs/10/static/error-style-guide.html)
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages? And if so, in which messages exactly they should be used?


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: Fixes for pgAdmin4 messages
Next
From: Dave Page
Date:
Subject: pgAdmin 4 commit: Update psycopg2 requirement to ensure 10.x+features