Thread: [BUGS] BUG #14643: Fails to compile with LibreSSL >= 2.5.3
The following bug has been logged on the website: Bug reference: 14643 Logged by: Pawel Pekala Email address: pawel@freebsd.org PostgreSQL version: 9.2.20 Operating system: FreeBSD Description: This bug is relevant to 9.3.16 release also. FreeBSD bug report (with patches): https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218736 Build error: cc -O2 -pipe -march=native -fstack-protector -fno-strict-aliasing -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -I../../../src/include -I/usr/local/include -I/usr/local/include/libxml2 -I/usr/include -I/usr/local/include -I/usr/local/include -c -o be-secure.o be-secure.c be-secure.c:341:19: error: no member named 'state' in 'struct ssl_st' if (port->ssl->state != SSL_ST_OK) ~~~~~~~~~ ^ be-secure.c:345:15: error: no member named 'state' in 'struct ssl_st' port->ssl->state |= SSL_ST_ACCEPT; ~~~~~~~~~ ^ be-secure.c:347:19: error: no member named 'state' in 'struct ssl_st' if (port->ssl->state != SSL_ST_OK) ~~~~~~~~~ ^ 3 errors generated. gmake[2]: *** [<builtin>: be-secure.o] Error 1 gmake[2]: Leaving directory '/usr/ports/databases/postgresql92-server/work/postgresql-9.2.20/src/backend/libpq' -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
pawel@freebsd.org writes: > FreeBSD bug report (with patches): > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218736 > Build error: > cc -O2 -pipe -march=native -fstack-protector -fno-strict-aliasing -Wall > -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement > -Wendif-labels -Wmissing-format-attribute -Wformat-security > -fno-strict-aliasing -fwrapv -I../../../src/include -I/usr/local/include > -I/usr/local/include/libxml2 -I/usr/include -I/usr/local/include > -I/usr/local/include -c -o be-secure.o be-secure.c > be-secure.c:341:19: error: no member named 'state' in 'struct ssl_st' > if (port->ssl->state != SSL_ST_OK) > ~~~~~~~~~ ^ > be-secure.c:345:15: error: no member named 'state' in 'struct ssl_st' > port->ssl->state |= SSL_ST_ACCEPT; > ~~~~~~~~~ ^ > be-secure.c:347:19: error: no member named 'state' in 'struct ssl_st' > if (port->ssl->state != SSL_ST_OK) > ~~~~~~~~~ ^ > 3 errors generated. > gmake[2]: *** [<builtin>: be-secure.o] Error 1 > gmake[2]: Leaving directory > '/usr/ports/databases/postgresql92-server/work/postgresql-9.2.20/src/backend/libpq' This looks like it was probably addressed by the changes we made last month to support OpenSSL 1.1.0 in our pre-9.5 branches. However, since LibreSSL isn't identical to OpenSSL, it would sure be nice if someone would verify compatibility before next week's update releases. Could you test against our git branch tips or nightly snapshot tarballs? regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 2017-05-04 20:57, Tom Lane wrote: > This looks like it was probably addressed by the changes we made last > month to support OpenSSL 1.1.0 in our pre-9.5 branches. However, since > LibreSSL isn't identical to OpenSSL, it would sure be nice if someone > would verify compatibility before next week's update releases. Could > you test against our git branch tips or nightly snapshot tarballs? For what it's worth my build farm animal loach is running FreeBSD 10.3 with LibreSSL 2.4.5 and it's running all branches from 9.2 to HEAD without complaining. It's not the newest version of LibreSSL though. /Mikael -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Mikael Kjellström <mikael.kjellstrom@mksoft.nu> writes:
> On 2017-05-04 20:57, Tom Lane wrote:
>> This looks like it was probably addressed by the changes we made last
>> month to support OpenSSL 1.1.0 in our pre-9.5 branches. However, since
>> LibreSSL isn't identical to OpenSSL, it would sure be nice if someone
>> would verify compatibility before next week's update releases. Could
>> you test against our git branch tips or nightly snapshot tarballs?
> For what it's worth my build farm animal loach is running FreeBSD 10.3
> with LibreSSL 2.4.5 and it's running all branches from 9.2 to HEAD
> without complaining.
> It's not the newest version of LibreSSL though.
Right. loach wasn't complaining before we made those fixes, either.
I'm guessing that Pawel is working with a bleeding-edge LibreSSL that
has adopted API changes similar to OpenSSL 1.1.0. The question now
is whether they're similar enough that our current code will work.
As I said, it'd be nice to find out this week not next week ...
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On 2017-05-04 21:35, Tom Lane wrote: >> For what it's worth my build farm animal loach is running FreeBSD 10.3 >> with LibreSSL 2.4.5 and it's running all branches from 9.2 to HEAD >> without complaining. > >> It's not the newest version of LibreSSL though. > > Right. loach wasn't complaining before we made those fixes, either. > I'm guessing that Pawel is working with a bleeding-edge LibreSSL that > has adopted API changes similar to OpenSSL 1.1.0. The question now > is whether they're similar enough that our current code will work. > As I said, it'd be nice to find out this week not next week ... There is a libressl-devel-2.5.2 available in the packages system that I could try and switch to if you want? Don't know if that is new enough for matching OpenSSL 1.1.0 API-changes though. /Mikael -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Mikael Kjellström <mikael.kjellstrom@mksoft.nu> writes:
> On 2017-05-04 21:35, Tom Lane wrote:
>> I'm guessing that Pawel is working with a bleeding-edge LibreSSL that
>> has adopted API changes similar to OpenSSL 1.1.0. The question now
>> is whether they're similar enough that our current code will work.
>> As I said, it'd be nice to find out this week not next week ...
> There is a libressl-devel-2.5.2 available in the packages system that I
> could try and switch to if you want? Don't know if that is new enough
> for matching OpenSSL 1.1.0 API-changes though.
Pawel specifies in $subject that you need 2.5.3 or later; if that's
accurate, 2.5.2 wouldn't show the problem.
In any case, if loach is still representative of what a lot of FreeBSD
people would be running, I'd counsel leaving it alone. Perhaps somebody
could set up another buildfarm animal with latest-n-greatest LibreSSL.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On 5/4/17, 2:55 PM, "Tom Lane" <pgsql-bugs-owner@postgresql.org on behalf of tgl@sss.pgh.pa.us> wrote:
Mikael Kjellström <mikael.kjellstrom@mksoft.nu> writes: > On 2017-05-04 21:35, Tom Lane wrote: >> I'm guessing
thatPawel is working with a bleeding-edge LibreSSL that >> has adopted API changes similar to OpenSSL 1.1.0. The
questionnow >> is whether they're similar enough that our current code will work. >> As I said, it'd be nice to
findout this week not next week ... > There is a libressl-devel-2.5.2 available in the packages system that I >
couldtry and switch to if you want? Don't know if that is new enough > for matching OpenSSL 1.1.0 API-changes
though. Pawel specifies in $subject that you need 2.5.3 or later; if that's accurate, 2.5.2 wouldn't show the
problem. In any case, if loach is still representative of what a lot of FreeBSD people would be running, I'd
counselleaving it alone. Perhaps somebody could set up another buildfarm animal with latest-n-greatest LibreSSL.
regards, tom lane
For the record, if y’all need something recent on FreeBSD, let me know. I’m now a ports committer there.
I also have enough horsepower at home to run an animal or 2 if you have a specific need/want.
--
Larry Rosenman http://www.lerctr.org/~ler
Phone: +1 214-642-9640 E-Mail: ler@lerctr.org
US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On 2017-05-04 15:03:17 -0500, Larry Rosenman wrote: > For the record, if y’all need something recent on FreeBSD, let me know. I’m now a ports committer there. > I also have enough horsepower at home to run an animal or 2 if you have a specific need/want. That surely would be appreciated, especially if it were tracking development reasonably closely and/or isn't on x86 (only have x86_64 animals). - Andres -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 5/4/17, 3:07 PM, "Andres Freund" <pgsql-bugs-owner@postgresql.org on behalf of andres@anarazel.de> wrote: On 2017-05-04 15:03:17 -0500, Larry Rosenman wrote: > For the record, if y’all need something recent on FreeBSD, letme know. I’m now a ports committer there. > I also have enough horsepower at home to run an animal or 2 if you havea specific need/want. That surely would be appreciated, especially if it were tracking development reasonablyclosely and/or isn't on x86 (only have x86_64 animals). - Andres It’s X86_64, but I think(!) I can set up others via QEMU (no real hardware available). I have it running FreeBSD –HEAD as the base, and a always (close to) current Ports Tree. (and It’s ZFS, so snaps, or what ever are easy). -- Larry Rosenman http://www.lerctr.org/~ler Phone: +1 214-642-9640 E-Mail: ler@lerctr.org US Mail: 17716 Limpia Crk, Round Rock, TX 78664-7281 -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 2017-05-04 15:10:59 -0500, Larry Rosenman wrote: > It’s X86_64, but I think(!) I can set up others via QEMU (no real hardware available). > > I have it running FreeBSD –HEAD as the base, and a always (close to) current Ports Tree. > > (and It’s ZFS, so snaps, or what ever are easy). Freebsd HEAD would be valuable on its own, "even" on x86-64. If you can emulate something else, that'd be good too, but I'm not sure how acceptable that ends up being performancewise. - Andres -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Hi Tom, On 2017-05-04 14:57 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote: >pawel@freebsd.org writes: >> FreeBSD bug report (with patches): >> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218736 > >> Build error: >> cc -O2 -pipe -march=native -fstack-protector -fno-strict-aliasing >> -Wall -Wmissing-prototypes -Wpointer-arith >> -Wdeclaration-after-statement -Wendif-labels >> -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing >> -fwrapv -I../../../src/include -I/usr/local/include >> -I/usr/local/include/libxml2 -I/usr/include -I/usr/local/include >> -I/usr/local/include -c -o be-secure.o be-secure.c >> be-secure.c:341:19: error: no member named 'state' in 'struct >> ssl_st' if (port->ssl->state != SSL_ST_OK) ~~~~~~~~~ ^ >> be-secure.c:345:15: error: no member named 'state' in 'struct ssl_st' >> port->ssl->state |= SSL_ST_ACCEPT; >> ~~~~~~~~~ ^ >> be-secure.c:347:19: error: no member named 'state' in 'struct ssl_st' >> if (port->ssl->state != SSL_ST_OK) >> ~~~~~~~~~ ^ >> 3 errors generated. >> gmake[2]: *** [<builtin>: be-secure.o] Error 1 >> gmake[2]: Leaving directory >> '/usr/ports/databases/postgresql92-server/work/postgresql-9.2.20/src/backend/libpq' > >This looks like it was probably addressed by the changes we made last >month to support OpenSSL 1.1.0 in our pre-9.5 branches. However, since >LibreSSL isn't identical to OpenSSL, it would sure be nice if someone >would verify compatibility before next week's update releases. Could >you test against our git branch tips or nightly snapshot tarballs? > > regards, tom lane I did quick builds of REL9_2_STABLE and REL9_3_STABLE and I can confirm they build fine with libressl-2.5.4. -- pozdrawiam / with regards Paweł Pękala -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 5/4/17, 3:19 PM, "Andres Freund" <andres@anarazel.de> wrote: On 2017-05-04 15:10:59 -0500, Larry Rosenman wrote: > It’s X86_64, but I think(!) I can set up others via QEMU (no realhardware available). > > I have it running FreeBSD –HEAD as the base, and a always (close to) current Ports Tree. > > (and It’s ZFS, so snaps, or what ever are easy). Freebsd HEAD would be valuable on its own, "even" onx86-64. If you can emulate something else, that'd be good too, but I'm not sure how acceptable that ends up beingperformancewise. - Andres I’ve forgotten the process (it’s been a LONG time) to set up a new animal (or 2). I can run whatever options y’all want. -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 2017-05-04 15:20:09 -0500, Larry Rosenman wrote: > > On 5/4/17, 3:19 PM, "Andres Freund" <andres@anarazel.de> wrote: > > On 2017-05-04 15:10:59 -0500, Larry Rosenman wrote: > > It’s X86_64, but I think(!) I can set up others via QEMU (no real hardware available). > > > > I have it running FreeBSD –HEAD as the base, and a always (close to) current Ports Tree. > > > > (and It’s ZFS, so snaps, or what ever are easy). > > Freebsd HEAD would be valuable on its own, "even" on x86-64. If you can > emulate something else, that'd be good too, but I'm not sure how > acceptable that ends up being performancewise. > > - Andres > > I’ve forgotten the process (it’s been a LONG time) to set up a new animal (or 2). Shouldn't be too hard: https://wiki.postgresql.org/wiki/PostgreSQL_Buildfarm_Howto https://buildfarm.postgresql.org/ - Andres -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Larry Rosenman <ler@lerctr.org> writes: > I’ve forgotten the process (it’s been a LONG time) to set up a new animal (or 2). It's reasonably well documented at https://buildfarm.postgresql.org/cgi-bin/register-form.pl and the wiki page linked from there. > I can run whatever options y’all want. Whatever floats your boat ... we don't want a monoculture of build options. regards, tom lane -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Andres Freund wrote: > On 2017-05-04 15:10:59 -0500, Larry Rosenman wrote: > > It’s X86_64, but I think(!) I can set up others via QEMU (no real hardware available). > > > > I have it running FreeBSD –HEAD as the base, and a always (close to) current Ports Tree. > > > > (and It’s ZFS, so snaps, or what ever are easy). > > Freebsd HEAD would be valuable on its own, "even" on x86-64. If you can > emulate something else, that'd be good too, but I'm not sure how > acceptable that ends up being performancewise. Slow machines are acceptable :-) without exotic options (such as valgrind or clobber cache) the tests shouldn't be *too* slow. It looks like FreeBSD 11.0 supports PPC, PPC64 and ARM64 (apart from "boring" x86 and AMD64), neither of which we have on buildfarm, so it'd be valuable to have those, besides whatever for FreeBSD HEAD. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Paweł Pękala <pawel@FreeBSD.org> writes:
> On 2017-05-04 14:57 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> This looks like it was probably addressed by the changes we made last
>> month to support OpenSSL 1.1.0 in our pre-9.5 branches. However, since
>> LibreSSL isn't identical to OpenSSL, it would sure be nice if someone
>> would verify compatibility before next week's update releases. Could
>> you test against our git branch tips or nightly snapshot tarballs?
> I did quick builds of REL9_2_STABLE and REL9_3_STABLE and I can confirm
> they build fine with libressl-2.5.4.
Thanks, appreciate the followup! Releases with these fixes will be out
in a week.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> It looks like FreeBSD 11.0 supports PPC, PPC64 and ARM64 (apart from
> "boring" x86 and AMD64), neither of which we have on buildfarm, so it'd
> be valuable to have those, besides whatever for FreeBSD HEAD.
FWIW, I spent a considerable amount of effort a few months ago trying to
get either 11.0 or CURRENT running on two different PPC Macs I've got
laying about. No dice :-(. I did get 10.3 to work, but since that's
already represented in the buildfarm it didn't seem as exciting.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
Tom Lane wrote: > Alvaro Herrera <alvherre@2ndquadrant.com> writes: > > It looks like FreeBSD 11.0 supports PPC, PPC64 and ARM64 (apart from > > "boring" x86 and AMD64), neither of which we have on buildfarm, so it'd > > be valuable to have those, besides whatever for FreeBSD HEAD. > > FWIW, I spent a considerable amount of effort a few months ago trying to > get either 11.0 or CURRENT running on two different PPC Macs I've got > laying about. No dice :-(. I did get 10.3 to work, but since that's > already represented in the buildfarm it didn't seem as exciting. Hmm ... some animal must have been retired, then, because currently there is no FreeBSD on PPC animal that I can see. All existing FreeBSD members are amd64. There is OpenBSD on PPC, though. Eh, I just notice that we lost spoonbill quite some time ago. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Tom Lane wrote:
>> FWIW, I spent a considerable amount of effort a few months ago trying to
>> get either 11.0 or CURRENT running on two different PPC Macs I've got
>> laying about. No dice :-(. I did get 10.3 to work, but since that's
>> already represented in the buildfarm it didn't seem as exciting.
> Hmm ... some animal must have been retired, then, because currently
> there is no FreeBSD on PPC animal that I can see. All existing FreeBSD
> members are amd64.
No, I meant that there was a 10.3/amd64 animal in the buildfarm, ie loach.
At the time (last December or so) we didn't have any FreeBSD >= 11 at all.
It looks like jaguarundi got updated since then.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
On 5/4/17, 5:24 PM, "Tom Lane" <pgsql-bugs-owner@postgresql.org on behalf of tgl@sss.pgh.pa.us> wrote: Alvaro Herrera <alvherre@2ndquadrant.com> writes: > Tom Lane wrote: >> FWIW, I spent a considerable amount of efforta few months ago trying to >> get either 11.0 or CURRENT running on two different PPC Macs I've got >> laying about. No dice :-(. I did get 10.3 to work, but since that's >> already represented in the buildfarm it didn't seem asexciting. > Hmm ... some animal must have been retired, then, because currently > there is no FreeBSD on PPC animalthat I can see. All existing FreeBSD > members are amd64. No, I meant that there was a 10.3/amd64 animal inthe buildfarm, ie loach. At the time (last December or so) we didn't have any FreeBSD >= 11 at all. It looks like jaguarundigot updated since then. regards, tom lane I’ve gotten my animal (peripatus) up with FreeBSD HEAD on all supported branches. It’s reporting in. The run_branches.pl runs every hour. -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
Larry Rosenman wrote: > I’ve gotten my animal (peripatus) up with FreeBSD HEAD on all supported branches. Great, thanks. > It’s reporting in. The run_branches.pl runs every hour. Note that the compiler version doesn't need to note that it may change in the future; in practice, many do. Just use the provided "update personality" script to update it whenever you get around to updating the compiler. Thanks -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs
On 5/5/17, 9:23 AM, "Alvaro Herrera" <alvherre@2ndquadrant.com> wrote: Larry Rosenman wrote: > I’ve gotten my animal (peripatus) up with FreeBSD HEAD on all supported branches. Great,thanks. > It’s reporting in. The run_branches.pl runs every hour. Note that the compiler version doesn'tneed to note that it may change in the future; in practice, many do. Just use the provided "update personality"script to update it whenever you get around to updating the compiler. Done. It should update next run. Didn’t know about the update_personality script ( -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs