Thread: [pgadmin-hackers] Translations Fix #1

Hello pgAdmin hackers,

this is my first suggestion for some translation improvements. It adds a space in front of all occurences of three dots at the end of a string which seems to be the correct language style. Initially I hoped that this would remove doubled strings like "Database" and "Database...", but it didn't. Either way, here is my patch dot.diff.

Please review/test. I'm currently not at home, so the source git [on which the diff was created] is not 100% current and I cannot test it myself.

There are going to be some other fixes that'll improve the application's messages.

Greetings from Germany,
Jonas Thelemann

Hi

On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
<e-mail@jonas-thelemann.de> wrote:
> Hello pgAdmin hackers,
>
> this is my first suggestion for some translation improvements. It adds a
> space in front of all occurences of three dots at the end of a string which
> seems to be the correct language style. Initially I hoped that this would
> remove doubled strings like "Database" and "Database...", but it didn't.
> Either way, here is my patch dot.diff.

I'm not clear why you believe this to be the correct formatting? As
far as I'm aware in English there wouldn't normally be a space - and
looking at Google Chrome, PyCharms and various Microsoft and Apple
apps, none of them seem to have a space before the '...'.

> There are going to be some other fixes that'll improve the application's
> messages.

Cool. You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.

Thanks, Dave.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

I'm not clear why you believe this to be the correct formatting?

Sorry, the link got removed. Here it is written out: http://english.stackexchange.com/questions/91653/space-before-three-dots
Again, I thought this would simplify the translation process which it didn't. Either way I googled that and found the stackexchange link above ^^

Would it be an alternative to exclude this kind of punctuation from the translatable strings? Like label: '{{ _('Cast') }} ...' (or similar) for example?

You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.

Yes, I (will) definitly do that. This idea was just a simple suggestion, nothing that impactful or important, if you ask me :)

Hi

On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
<e-mail@jonas-thelemann.de> wrote:

Hello pgAdmin hackers,

this is my first suggestion for some translation improvements. It adds a
space in front of all occurences of three dots at the end of a string which
seems to be the correct language style. Initially I hoped that this would
remove doubled strings like "Database" and "Database...", but it didn't.
Either way, here is my patch dot.diff.

I'm not clear why you believe this to be the correct formatting? As
far as I'm aware in English there wouldn't normally be a space - and
looking at Google Chrome, PyCharms and various Microsoft and Apple
apps, none of them seem to have a space before the '...'.

There are going to be some other fixes that'll improve the application's
messages.

Cool. You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.

Thanks, Dave.

On Mon, Mar 20, 2017 at 8:59 PM, Jonas Thelemann
<e-mail@jonas-thelemann.de> wrote:
> I'm not clear why you believe this to be the correct formatting?
>
> Sorry, the link got removed. Here it is written out:
> http://english.stackexchange.com/questions/91653/space-before-three-dots
> Again, I thought this would simplify the translation process which it
> didn't. Either way I googled that and found the stackexchange link above ^^
>
> Would it be an alternative to exclude this kind of punctuation from the
> translatable strings? Like label: '{{ _('Cast') }} ...' (or similar) for
> example?

I don't see any reason that wouldn't work, unless it doesn't make
sense or follow convention in (for example) Japanese or Chinese.

> You might want to discuss any non-trivial fixes here first
> before doing lots of work, just to make sure we're all in agreement
> before you spend significant amounts of time on anything.
>
> Yes, I (will) definitly do that. This idea was just a simple suggestion,
> nothing that impactful or important, if you ask me :)

No, but it must have taken some of your time to create the patch, and
I'd prefer to avoid wasting that if it means you can work on something
of more value :-)

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company