Re: [pgadmin-hackers] Translations Fix #1 - Mailing list pgadmin-hackers

From Jonas Thelemann
Subject Re: [pgadmin-hackers] Translations Fix #1
Date
Msg-id ae6e5feb-ecf4-b47b-0af4-d37e2b0acc58@jonas-thelemann.de
Whole thread Raw
In response to Re: [pgadmin-hackers] Translations Fix #1  (Dave Page <dpage@pgadmin.org>)
Responses Re: [pgadmin-hackers] Translations Fix #1
List pgadmin-hackers

I'm not clear why you believe this to be the correct formatting?
Sorry, the link got removed. Here it is written out: http://english.stackexchange.com/questions/91653/space-before-three-dots
Again, I thought this would simplify the translation process which it didn't. Either way I googled that and found the stackexchange link above ^^

Would it be an alternative to exclude this kind of punctuation from the translatable strings? Like label: '{{ _('Cast') }} ...' (or similar) for example?

You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.
Yes, I (will) definitly do that. This idea was just a simple suggestion, nothing that impactful or important, if you ask me :)

Am 20.03.2017 um 11:51 schrieb Dave Page:
Hi

On Fri, Mar 17, 2017 at 10:12 PM, Jonas Thelemann
<e-mail@jonas-thelemann.de> wrote:
Hello pgAdmin hackers,

this is my first suggestion for some translation improvements. It adds a
space in front of all occurences of three dots at the end of a string which
seems to be the correct language style. Initially I hoped that this would
remove doubled strings like "Database" and "Database...", but it didn't.
Either way, here is my patch dot.diff.
I'm not clear why you believe this to be the correct formatting? As
far as I'm aware in English there wouldn't normally be a space - and
looking at Google Chrome, PyCharms and various Microsoft and Apple
apps, none of them seem to have a space before the '...'.

There are going to be some other fixes that'll improve the application's
messages.
Cool. You might want to discuss any non-trivial fixes here first
before doing lots of work, just to make sure we're all in agreement
before you spend significant amounts of time on anything.

Thanks, Dave.


pgadmin-hackers by date:

Previous
From: Atira Odhner
Date:
Subject: Re: [pgadmin-hackers] Feature test regression failures
Next
From: Ashesh Vashi
Date:
Subject: [pgadmin-hackers] pgAdmin 4 commit: Resolved a typo - show a '?' after the 'Showtiming'