Thread: planstate_tree_walker
In my reviews of Amit's parallel sequential scan patches yesterday, I complained that he was using planstate_tree_walker incorrectly, but I failed to notice that this was because he'd defined planstate_tree_walker incorrectly. This morning I figured that out. :-) Here is a patch that *just* introduces planstate_tree_walker and which is hopefully correct. I stole the logic from ExplainPreScanNode, which I also refactored to use the new walker instead of duplicating the logic. I'd like to go ahead and commit this if nobody sees a problem with it. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
Attachment
Robert Haas <robertmhaas@gmail.com> writes:
> Here is a patch that *just* introduces planstate_tree_walker and which
> is hopefully correct. I stole the logic from ExplainPreScanNode,
> which I also refactored to use the new walker instead of duplicating
> the logic.
It seems a little odd to have removed functions from explain.c altogether
but left their header comments behind. Otherwise this seems sound.
regards, tom lane
On Thu, Sep 17, 2015 at 9:33 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote: > Robert Haas <robertmhaas@gmail.com> writes: >> Here is a patch that *just* introduces planstate_tree_walker and which >> is hopefully correct. I stole the logic from ExplainPreScanNode, >> which I also refactored to use the new walker instead of duplicating >> the logic. > > It seems a little odd to have removed functions from explain.c altogether > but left their header comments behind. Otherwise this seems sound. D'oh! OK, will fix that before committing. Thanks. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company