Re: planstate_tree_walker - Mailing list pgsql-hackers

From Robert Haas
Subject Re: planstate_tree_walker
Date
Msg-id CA+TgmoYcwEM6RstquXbKfGJ9F3DbfRFRnRZMDPHkHV-nqr_7fA@mail.gmail.com
Whole thread Raw
In response to Re: planstate_tree_walker  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, Sep 17, 2015 at 9:33 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
>> Here is a patch that *just* introduces planstate_tree_walker and which
>> is hopefully correct.  I stole the logic from ExplainPreScanNode,
>> which I also refactored to use the new walker instead of duplicating
>> the logic.
>
> It seems a little odd to have removed functions from explain.c altogether
> but left their header comments behind.  Otherwise this seems sound.

D'oh!

OK, will fix that before committing.  Thanks.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



pgsql-hackers by date:

Previous
From: Andrew Dunstan
Date:
Subject: honour TEMP_CONFIG in pg_upgrade tests
Next
From: Tom Lane
Date:
Subject: Re: honour TEMP_CONFIG in pg_upgrade tests