Thread: Incorrect comment in postgres_fdw.c
I think the following comment for store_returning_result() in
postgres_fdw.c is not right.
/* PGresult must be released before leaving this function. */
I think PGresult should not be released before leaving this function *on
success* in that function.
(I guess the comment has been copied and pasted from that for
get_remote_estimate().)
Thanks,
Best regards,
Etsuro Fujita
Attachment
Fujita-san, 2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>: > I think the following comment for store_returning_result() in > postgres_fdw.c is not right. > > /* PGresult must be released before leaving this function. */ > > I think PGresult should not be released before leaving this function *on > success* in that function. > > (I guess the comment has been copied and pasted from that for > get_remote_estimate().) +1 for just removing the comment, because header comment clearly mentions necessity of releasing the PGresult. -- Shigeru HANADA
On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada <shigeru.hanada@gmail.com> wrote: > Fujita-san, > > 2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>: >> I think the following comment for store_returning_result() in >> postgres_fdw.c is not right. >> >> /* PGresult must be released before leaving this function. */ >> >> I think PGresult should not be released before leaving this function *on >> success* in that function. >> >> (I guess the comment has been copied and pasted from that for >> get_remote_estimate().) > > +1 for just removing the comment, because header comment clearly > mentions necessity of releasing the PGresult. Committed. Thanks for the report! Regards, -- Fujii Masao
(2014/07/14 19:46), Fujii Masao wrote: > On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada > <shigeru.hanada@gmail.com> wrote: >> Fujita-san, >> >> 2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>: >>> I think the following comment for store_returning_result() in >>> postgres_fdw.c is not right. >>> >>> /* PGresult must be released before leaving this function. */ >>> >>> I think PGresult should not be released before leaving this function *on >>> success* in that function. >>> >>> (I guess the comment has been copied and pasted from that for >>> get_remote_estimate().) >> >> +1 for just removing the comment, because header comment clearly >> mentions necessity of releasing the PGresult. > > Committed. Thanks for the report! Thank you for committing the patch! And thanks, Hanada-san! Best regards, Etsuro Fujita