Postgres Pro
Downloads
Home   >   mailing lists

Re: Incorrect comment in postgres_fdw.c - Mailing list pgsql-hackers

From Shigeru Hanada
Subject Re: Incorrect comment in postgres_fdw.c
Date
Msg-id CAEZqfEfBpJP+kNBeOuaB-B_euBWHJR_EhXsgST5fmf1dZLLxdg@mail.gmail.com
Whole thread Raw
In response to Incorrect comment in postgres_fdw.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
Responses Re: Incorrect comment in postgres_fdw.c  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Tree view 
Fujita-san,

2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>:
> I think the following comment for store_returning_result() in
> postgres_fdw.c is not right.
>
>     /* PGresult must be released before leaving this function. */
>
> I think PGresult should not be released before leaving this function *on
> success* in that function.
>
> (I guess the comment has been copied and pasted from that for
> get_remote_estimate().)

+1 for just removing the comment, because header comment clearly
mentions necessity of releasing the PGresult.


-- 
Shigeru HANADA

pgsql-hackers by date:

Previous
From: Abhijit Menon-Sen
Date:
Subject: Re: pg_shmem_allocations view
Next
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Use unique index for longer pathkeys.