Re: Incorrect comment in postgres_fdw.c - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Incorrect comment in postgres_fdw.c
Date
Msg-id CAHGQGwFp3xS3YxKZw1Hr=3XGP7uaJen6mwjZJVn5c30kNt9Z9g@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect comment in postgres_fdw.c  (Shigeru Hanada <shigeru.hanada@gmail.com>)
Responses Re: Incorrect comment in postgres_fdw.c  (Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>)
List pgsql-hackers
On Mon, Jul 14, 2014 at 7:31 PM, Shigeru Hanada
<shigeru.hanada@gmail.com> wrote:
> Fujita-san,
>
> 2014-07-11 18:22 GMT+09:00 Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>:
>> I think the following comment for store_returning_result() in
>> postgres_fdw.c is not right.
>>
>>     /* PGresult must be released before leaving this function. */
>>
>> I think PGresult should not be released before leaving this function *on
>> success* in that function.
>>
>> (I guess the comment has been copied and pasted from that for
>> get_remote_estimate().)
>
> +1 for just removing the comment, because header comment clearly
> mentions necessity of releasing the PGresult.

Committed. Thanks for the report!

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Kyotaro HORIGUCHI
Date:
Subject: Re: Use unique index for longer pathkeys.
Next
From: Tom Lane
Date:
Subject: Re: Re: issue log message to suggest VACUUM FULL if a table is nearly empty