Postgres Pro
Downloads
Home   >   mailing lists

Incorrect comment in postgres_fdw.c - Mailing list pgsql-hackers

From Etsuro Fujita
Subject Incorrect comment in postgres_fdw.c
Date
Msg-id 53BFACBC.9000503@lab.ntt.co.jp
Whole thread Raw
Responses Re: Incorrect comment in postgres_fdw.c  (Shigeru Hanada <shigeru.hanada@gmail.com>)
List pgsql-hackers
Tree view 
I think the following comment for store_returning_result() in
postgres_fdw.c is not right.

    /* PGresult must be released before leaving this function. */

I think PGresult should not be released before leaving this function *on
success* in that function.

(I guess the comment has been copied and pasted from that for
get_remote_estimate().)

Thanks,

Best regards,
Etsuro Fujita
Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: pg_receivexlog and replication slots
Next
From: "Tomas Vondra"
Date:
Subject: Re: tweaking NTUP_PER_BUCKET