Postgres Pro
Downloads
Home   >   mailing lists

Thread: Patch for CREATE RULE sgml -- Was in: [DOCS]

Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Emanuel Calvo
Date:
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512



Hi guys,

I realized that the output of the CREATE RULE has not a detailed
output for the "events" parameter.

But the question here is that I'm not sure which format follow:

{ INSERT | UPDATE | DELETE | SELECT}

or

    INSERT
    UPDATE
    DELETE
    SELECT
- --


I attach a patch for each one.

I sent a mail to pgsql-docs but no response has been received.

Thanks and regards,


-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.18 (Darwin)
Comment: GPGTools - http://gpgtools.org
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBCgAGBQJTLGERAAoJEIBeI/HMagHmUYcP/ibZQaTYDgLmclqgv6wbeTnT
m9d9mhYEJVhdyowGcJ5s+OSCN5tj2vGJifjxUAQ+6hW+0mzj9kqQLoWJyb9DYn1o
AbbUM6+p2Q1+P5KAUYMVZDRiGN6EqFPw2BgsXhIA2rXHT/PiSPpKvFK6wQ0rmSyX
houtfrXEl4zzLHyrmHZmWHyz6DgPyTM/jtHTd/yhAl1OxKR5V583bHEfDUz3zYEX
v6NjBiq5TY6uaXVF0B0cya8nRfW3KP240cwZTF5zRoyHZ1LNlHLPEPs2huNZPLbk
tp3UIHhdiZKl7ddJcWTTeuv4ABQXQVBLQwHWR91szMr+dz/Wsk0zmeFNzlCKCzzN
cehz5n6yewIiosS1MlD7lxOAHPN0yiXtsjiOWoQYbLaxkcTO74oUZK1iWXD025TB
vSegM0L1a1GJFNjyZhQnUgMLWELhsC5y1g7Pn7D9YkzeyicEFtFRTkGDR9eh9LmV
PNtV4w5M/hZtbappfoW7IL6tLtZnjHUA+UjPflnoae0uQ8G+MOW+3rkXt30BksdR
VXvbhXTXaKLj2cEs8cfyBuVUs8AwBGssjfX2OxkSYjvGYcHVoSN/o0cqOWUD/mMi
98ORZcLrzWk70kQ0zxW9wIXbkp4M+8uogyzL9ViveiLREHYD9SRlWMGPpgbcs/aM
fB7fgznJGvXZoRefJKdQ
=UWLa
-----END PGP SIGNATURE-----
Attachment

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Michael Paquier
Date:
On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:
> I realized that the output of the CREATE RULE has not a detailed
> output for the "events" parameter.
>
> But the question here is that I'm not sure which format follow:
>
> { INSERT | UPDATE | DELETE | SELECT}
>
> or
>
>     INSERT
>     UPDATE
>     DELETE
>     SELECT
> - --
>
>
> I attach a patch for each one.
>
> I sent a mail to pgsql-docs but no response has been received.
The list of events possible is already listed in the section
"Parameters" => "event":
Page: http://www.postgresql.org/docs/devel/static/sql-createrule.html
Quote: "The event is one of SELECT, INSERT, UPDATE, or DELETE."
Regards,
-- 
Michael

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Jaime Casanova
Date:
On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
>
> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
> <emanuel.calvo@2ndquadrant.com> wrote:
> > I realized that the output of the CREATE RULE has not a detailed
> > output for the "events" parameter.
> >
> The list of events possible is already listed in the section
> "Parameters" => "event":

AFAIU, the synopsis is used to build the help command (\h) in psql.
Currently in that help the events doesn't appear.
btw, CREATE TRIGGER already looks this way:
http://www.postgresql.org/docs/current/static/sql-createtrigger.html

--
Jaime Casanova         www.2ndQuadrant.com
Professional PostgreSQL: Soporte 24x7 y capacitación
Phone: +593 4 5107566         Cell: +593 987171157

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Michael Paquier
Date:
On Sat, Mar 22, 2014 at 11:18 AM, Jaime Casanova <jaime@2ndquadrant.com> wrote:
> On Fri, Mar 21, 2014 at 8:15 PM, Michael Paquier
> <michael.paquier@gmail.com> wrote:
>>
>> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
>> <emanuel.calvo@2ndquadrant.com> wrote:
>> > I realized that the output of the CREATE RULE has not a detailed
>> > output for the "events" parameter.
>> >
>> The list of events possible is already listed in the section
>> "Parameters" => "event":
>
> AFAIU, the synopsis is used to build the help command (\h) in psql.
> Currently in that help the events doesn't appear.
> btw, CREATE TRIGGER already looks this way:
> http://www.postgresql.org/docs/current/static/sql-createtrigger.html
You are right, I forgot this one... In this case patch 2 could be backpatched...
-- 
Michael

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Fujii Masao
Date:
On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
<emanuel.calvo@2ndquadrant.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
>
>
> Hi guys,
>
> I realized that the output of the CREATE RULE has not a detailed
> output for the "events" parameter.
>
> But the question here is that I'm not sure which format follow:
>
> { INSERT | UPDATE | DELETE | SELECT}
>
> or
>
>     INSERT
>     UPDATE
>     DELETE
>     SELECT
> - --
>
>
> I attach a patch for each one.

Though I'm not sure the right policy of the format in synopsis, ISTM that
the following format is suitable in this case, i.e., if the value list
is very simple.
Patch attached.

    SELECT | INSERT | UPDATE | DELETE

Regards,

--
Fujii Masao
Attachment

Re: Patch for CREATE RULE sgml -- Was in: [DOCS]

From
Bruce Momjian
Date:
On Mon, Mar 24, 2014 at 09:51:07PM +0900, Fujii Masao wrote:
> On Sat, Mar 22, 2014 at 12:56 AM, Emanuel Calvo
> <emanuel.calvo@2ndquadrant.com> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA512
> >
> >
> >
> > Hi guys,
> >
> > I realized that the output of the CREATE RULE has not a detailed
> > output for the "events" parameter.
> >
> > But the question here is that I'm not sure which format follow:
> >
> > { INSERT | UPDATE | DELETE | SELECT}
> >
> > or
> >
> >     INSERT
> >     UPDATE
> >     DELETE
> >     SELECT
> > - --
> >
> >
> > I attach a patch for each one.
> 
> Though I'm not sure the right policy of the format in synopsis, ISTM that
> the following format is suitable in this case, i.e., if the value list
> is very simple.
> Patch attached.
> 
>     SELECT | INSERT | UPDATE | DELETE

Patch applied.

--  Bruce Momjian  <bruce@momjian.us>        http://momjian.us EnterpriseDB
http://enterprisedb.com
 + Everyone has their own god. +