Thread: Server specific advanced config file for testsuite
Hi Dave,
As we know that, we are using two JSON files one is for basic configuration of server(test_config.json) and second for detailed configuration of server(test_advanced_config.json).
In test_advanced_config.json, we give detail for database, schema, extension, collation etc. These details are generic I mean these details are not server specific.
- Do we need to allow user to give server specific details?
If yes, there should be some identification(like ‘server_type’, ‘version’) for each detail so that we can read server appropriate details.
We have one approach in mind, to attach 'server_type' & 'version' to each detail
So, modified test_advanced_config.json can be like this,
{
"add_database_data”:[
{
"conn_limit": -1,
“owner”: “postres”,
.
.
.
.
“server_type”: “pg”,
“version”: “pg9.4”
},
{
{
"conn_limit": -1,
“owner”: “enterprisedb”,
.
.
.
.
“server_type”: “ppas”,
“version”: “ppas9.6”
}
}],
“schema_credentials”:
[{"func_acl": [],
"seq_acl": [],
.
.
.
.
“server_type”: “pg”,
“version”: “pg9.4”
}]
.
.
.
.
.
}
Any suggestions?
For multiple server currently we used 'owner' to identify the server, but that fails if two servers have the same owner.
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878
Hi On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote: > Hi Dave, > As we know that, we are using two JSON files one is for basic > configuration of server(test_config.json) and second for detailed > configuration of server(test_advanced_config.json). > In test_advanced_config.json, we give detail for database, schema, > extension, collation etc. These details are generic I mean these details are > not server specific. > - Do we need to allow user to give server specific details? I don't see any reason to do so. Honestly I don't see much need for test_advanced_config.json at all - I can't see anyone ever customising the tests. I certainly doubt I will. > If yes, there should be some identification(like ‘server_type’, ‘version’) > for each detail so that we can read server appropriate details. > We have one approach in mind, to attach 'server_type' & 'version' to each > detail > So, modified test_advanced_config.json can be like this, > { > "add_database_data”:[ > { > "conn_limit": -1, > “owner”: “postres”, > . > . > . > . > “server_type”: “pg”, > “version”: “pg9.4” > }, > { > { > "conn_limit": -1, > “owner”: “enterprisedb”, > . > . > . > . > “server_type”: “ppas”, > “version”: “ppas9.6” > } > }], > “schema_credentials”: > [{"func_acl": [], > "seq_acl": [], > . > . > . > . > “server_type”: “pg”, > “version”: “pg9.4” > }] > . > . > . > . > . > } > > Any suggestions? > > For multiple server currently we used 'owner' to identify the server, but > that fails if two servers have the same owner. > > > -- > Thanks, > Navnath Gadakh > Software Engineer > EnterpriseDB Corporation > Mobile: +91 9975389878 > > -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
BTW - I need the updated code that fixes all outstanding issues this week please. Release is coming up fast... On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <dave.page@enterprisedb.com> wrote: > Hi > > On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh > <navnath.gadakh@enterprisedb.com> wrote: >> Hi Dave, >> As we know that, we are using two JSON files one is for basic >> configuration of server(test_config.json) and second for detailed >> configuration of server(test_advanced_config.json). >> In test_advanced_config.json, we give detail for database, schema, >> extension, collation etc. These details are generic I mean these details are >> not server specific. >> - Do we need to allow user to give server specific details? > > I don't see any reason to do so. Honestly I don't see much need for > test_advanced_config.json at all - I can't see anyone ever customising > the tests. I certainly doubt I will. > >> If yes, there should be some identification(like ‘server_type’, ‘version’) >> for each detail so that we can read server appropriate details. >> We have one approach in mind, to attach 'server_type' & 'version' to each >> detail >> So, modified test_advanced_config.json can be like this, >> { >> "add_database_data”:[ >> { >> "conn_limit": -1, >> “owner”: “postres”, >> . >> . >> . >> . >> “server_type”: “pg”, >> “version”: “pg9.4” >> }, >> { >> { >> "conn_limit": -1, >> “owner”: “enterprisedb”, >> . >> . >> . >> . >> “server_type”: “ppas”, >> “version”: “ppas9.6” >> } >> }], >> “schema_credentials”: >> [{"func_acl": [], >> "seq_acl": [], >> . >> . >> . >> . >> “server_type”: “pg”, >> “version”: “pg9.4” >> }] >> . >> . >> . >> . >> . >> } >> >> Any suggestions? >> >> For multiple server currently we used 'owner' to identify the server, but >> that fails if two servers have the same owner. >> >> >> -- >> Thanks, >> Navnath Gadakh >> Software Engineer >> EnterpriseDB Corporation >> Mobile: +91 9975389878 >> >> > > > > -- > Dave Page > VP, Chief Architect, Tools & Installers > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
Hi,
--
On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <dave.page@enterprisedb.com> wrote:
BTW - I need the updated code that fixes all outstanding issues this
week please. Release is coming up fast...
Yes. The enhanced test result is already completed, but before that drop objects functionality is needed to complete. Which is already done for servers & databases. So I will send a patch for these two nodes today & after that for the remaining nodes(need some modifications in existing setup & teardown for each test module)
We will try to finish this work end of this week.
Thanks.
On Tue, Sep 13, 2016 at 9:48 AM, Dave Page <dave.page@enterprisedb.com> wrote:
> Hi
>
> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
> <navnath.gadakh@enterprisedb.com> wrote:
>> Hi Dave,
>> As we know that, we are using two JSON files one is for basic
>> configuration of server(test_config.json) and second for detailed
>> configuration of server(test_advanced_config.json).
>> In test_advanced_config.json, we give detail for database, schema,
>> extension, collation etc. These details are generic I mean these details are
>> not server specific.
>> - Do we need to allow user to give server specific details?
>
> I don't see any reason to do so. Honestly I don't see much need for
> test_advanced_config.json at all - I can't see anyone ever customising
> the tests. I certainly doubt I will.
>
>> If yes, there should be some identification(like ‘server_type’, ‘version’)
>> for each detail so that we can read server appropriate details.
>> We have one approach in mind, to attach 'server_type' & 'version' to each
>> detail
>> So, modified test_advanced_config.json can be like this,
>> {
>> "add_database_data”:[
>> {
>> "conn_limit": -1,
>> “owner”: “postres”,
>> .
>> .
>> .
>> .
>> “server_type”: “pg”,
>> “version”: “pg9.4”
>> },
>> {
>> {
>> "conn_limit": -1,
>> “owner”: “enterprisedb”,
>> .
>> .
>> .
>> .
>> “server_type”: “ppas”,
>> “version”: “ppas9.6”
>> }
>> }],
>> “schema_credentials”:
>> [{"func_acl": [],
>> "seq_acl": [],
>> .
>> .
>> .
>> .
>> “server_type”: “pg”,
>> “version”: “pg9.4”
>> }]
>> .
>> .
>> .
>> .
>> .
>> }
>>
>> Any suggestions?
>>
>> For multiple server currently we used 'owner' to identify the server, but
>> that fails if two servers have the same owner.
>>
>>
>> --
>> Thanks,
>> Navnath Gadakh
>> Software Engineer
>> EnterpriseDB Corporation
>> Mobile: +91 9975389878
>>
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
--
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878
On Tue, Sep 13, 2016 at 10:06 AM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote: > Hi, > > On Tue, Sep 13, 2016 at 2:18 PM, Dave Page <dave.page@enterprisedb.com> > wrote: >> >> BTW - I need the updated code that fixes all outstanding issues this >> week please. Release is coming up fast... > > Yes. The enhanced test result is already completed, but before that drop > objects functionality is needed to complete. Which is already done for > servers & databases. So I will send a patch for these two nodes today & > after that for the remaining nodes(need some modifications in existing setup > & teardown for each test module) > > We will try to finish this work end of this week. https://goo.gl/FiPllO :-) -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake
On 13 September 2016 at 14:18, Dave Page <dave.page@enterprisedb.com> wrote:
Hi
On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh
<navnath.gadakh@enterprisedb.com> wrote:
> Hi Dave,
> As we know that, we are using two JSON files one is for basic
> configuration of server(test_config.json) and second for detailed
> configuration of server(test_advanced_config.json).
> In test_advanced_config.json, we give detail for database, schema,
> extension, collation etc. These details are generic I mean these details are
> not server specific.
> - Do we need to allow user to give server specific details?
I don't see any reason to do so. Honestly I don't see much need for
test_advanced_config.json at all - I can't see anyone ever customising
the tests. I certainly doubt I will.
As per your suggestion, I have added test data to test_advanced_config.json which will be used/changed by advanced user.
test_advanced_config.json contain test data for all nodes (i.e. database, schema, tablespace etc..) except server.
If we dont use test_advanced_config.json file, from where we can fetch test data for all nodes?
We wants to edit test_advanced_config.json as per server type and version as there are 2 types of
servers available i.e. PostgreSQL and EPAS which might have different test data as per server type.
e.g. "owner": in case of PG it can be owner: "postgres"
which may not be available for EPAS, for EPAS it can be "enterprisedb" or vice versa.
If we do not modify the tests and run testsuite it will fail for multiple servers.
--
> If yes, there should be some identification(like ‘server_type’, ‘version’)
> for each detail so that we can read server appropriate details.
> We have one approach in mind, to attach 'server_type' & 'version' to each
> detail
> So, modified test_advanced_config.json can be like this,
> {
> "add_database_data”:[
> {
> "conn_limit": -1,
> “owner”: “postres”,
> .
> .
> .
> .
> “server_type”: “pg”,
> “version”: “pg9.4”
> },
> {
> {
> "conn_limit": -1,
> “owner”: “enterprisedb”,
> .
> .
> .
> .
> “server_type”: “ppas”,
> “version”: “ppas9.6”
> }
> }],
> “schema_credentials”:
> [{"func_acl": [],
> "seq_acl": [],
> .
> .
> .
> .
> “server_type”: “pg”,
> “version”: “pg9.4”
> }]
> .
> .
> .
> .
> .
> }
>
> Any suggestions?
>
> For multiple server currently we used 'owner' to identify the server, but
> that fails if two servers have the same owner.
>
>
> --
> Thanks,
> Navnath Gadakh
> Software Engineer
> EnterpriseDB Corporation
> Mobile: +91 9975389878
>
>
Dave Page
VP, Chief Architect, Tools & Installers
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Best,
Priyanka
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
The Enterprise PostgreSQL Company
Hi On Tue, Sep 13, 2016 at 1:09 PM, Priyanka Shendge <priyanka.shendge@enterprisedb.com> wrote: > > > On 13 September 2016 at 14:18, Dave Page <dave.page@enterprisedb.com> wrote: >> >> Hi >> >> On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh >> <navnath.gadakh@enterprisedb.com> wrote: >> > Hi Dave, >> > As we know that, we are using two JSON files one is for basic >> > configuration of server(test_config.json) and second for detailed >> > configuration of server(test_advanced_config.json). >> > In test_advanced_config.json, we give detail for database, schema, >> > extension, collation etc. These details are generic I mean these details >> > are >> > not server specific. >> > - Do we need to allow user to give server specific details? >> >> I don't see any reason to do so. Honestly I don't see much need for >> test_advanced_config.json at all - I can't see anyone ever customising >> the tests. I certainly doubt I will. > > > As per your suggestion, I have added test data to test_advanced_config.json > which will be used/changed by advanced user. I suggested it because I didn't think it should all be in the main config file. I didn't realise it was going to get so big at the time. > test_advanced_config.json contain test data for all nodes (i.e. database, > schema, tablespace etc..) except server. > If we dont use test_advanced_config.json file, from where we can fetch test > data for all nodes? Hard-code it in the tests. > We wants to edit test_advanced_config.json as per server type and version as > there are 2 types of > servers available i.e. PostgreSQL and EPAS which might have different test > data as per server type. > e.g. "owner": in case of PG it can be owner: "postgres" > which may not be available for EPAS, for EPAS it can be "enterprisedb" or > vice versa. But that data is in the server config (test_config.json). > If we do not modify the tests and run testsuite it will fail for multiple > servers. I honestly don't see why anything other than server-specific values (i.e. connection info, tablespace path) needs to be customisable. -- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company Blog: http://pgsnake.blogspot.com Twitter: @pgsnake