Hi On Mon, Sep 12, 2016 at 6:26 PM, Navnath Gadakh <navnath.gadakh@enterprisedb.com> wrote: > Hi Dave, > As we know that, we are using two JSON files one is for basic > configuration of server(test_config.json) and second for detailed > configuration of server(test_advanced_config.json). > In test_advanced_config.json, we give detail for database, schema, > extension, collation etc. These details are generic I mean these details are > not server specific. > - Do we need to allow user to give server specific details?
I don't see any reason to do so. Honestly I don't see much need for test_advanced_config.json at all - I can't see anyone ever customising the tests. I certainly doubt I will.
As per your suggestion, I have added test data to test_advanced_config.json which will be used/changed by advanced user.
test_advanced_config.json contain test data for all nodes (i.e. database, schema, tablespace etc..) except server.
If we dont use test_advanced_config.json file, from where we can fetch test data for all nodes?
We wants to edit test_advanced_config.json as per server type and version as there are 2 types of
servers available i.e. PostgreSQL and EPAS which might have different test data as per server type.
e.g. "owner": in case of PG it can be owner: "postgres"
which may not be available for EPAS, for EPAS it can be "enterprisedb" or vice versa.
If we do not modify the tests and run testsuite it will fail for multiple servers.
> If yes, there should be some identification(like ‘server_type’, ‘version’) > for each detail so that we can read server appropriate details. > We have one approach in mind, to attach 'server_type' & 'version' to each > detail > So, modified test_advanced_config.json can be like this, > { > "add_database_data”:[ > { > "conn_limit": -1, > “owner”: “postres”, > . > . > . > . > “server_type”: “pg”, > “version”: “pg9.4” > }, > { > { > "conn_limit": -1, > “owner”: “enterprisedb”, > . > . > . > . > “server_type”: “ppas”, > “version”: “ppas9.6” > } > }], > “schema_credentials”: > [{"func_acl": [], > "seq_acl": [], > . > . > . > . > “server_type”: “pg”, > “version”: “pg9.4” > }] > . > . > . > . > . > } > > Any suggestions? > > For multiple server currently we used 'owner' to identify the server, but > that fails if two servers have the same owner. > > > -- > Thanks, > Navnath Gadakh > Software Engineer > EnterpriseDB Corporation > Mobile: +91 9975389878 > >
-- Dave Page VP, Chief Architect, Tools & Installers EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
