Re: [POC] A better way to expand hash indexes. - Mailing list pgsql-hackers

From Jesper Pedersen
Subject Re: [POC] A better way to expand hash indexes.
Date
Msg-id d87ed9ca-f859-bc96-c896-e866716ab380@redhat.com
Whole thread Raw
In response to [HACKERS] [POC] A better way to expand hash indexes.  (Mithun Cy <mithun.cy@enterprisedb.com>)
Responses Re: [POC] A better way to expand hash indexes.  (Mithun Cy <mithun.cy@enterprisedb.com>)
List pgsql-hackers
Hi Mithun,

On 03/26/2017 01:56 AM, Mithun Cy wrote:
> Thanks, Amit for the review.
> On Sat, Mar 25, 2017 at 7:03 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>
>> I think one-dimensional patch has fewer places to touch, so that looks
>> better to me.  However, I think there is still hard coding and
>> assumptions in code which we should try to improve.
>
> Great!, I will continue with spares 1-dimensional improvement.
>

I ran some performance scenarios on the patch to see if the increased 
'spares' allocation had an impact. I havn't found any regressions in 
that regard.

Attached patch contains some small fixes, mainly to the documentation - 
on top of v7.

Best regards,
  Jesper


pgsql-hackers by date:

Previous
From: Alexander Korotkov
Date:
Subject: Re: Unused argument in PinBuffer function
Next
From: Andreas Seltenreich
Date:
Subject: Re: [sqlsmith] Failed assertion in _hash_kill_items/MarkBufferDirtyHint