Postgres Pro
Downloads
Home   >   mailing lists

Re: Unused argument in PinBuffer function - Mailing list pgsql-hackers

From Alexander Korotkov
Subject Re: Unused argument in PinBuffer function
Date
Msg-id CAPpHfdsfxOS4XNhLuNgSkG=1KtsHrmwcUn+HdAcphRc+WUBrYw@mail.gmail.com
Whole thread Raw
In response to Unused argument in PinBuffer function  (Ildar Musin <i.musin@postgrespro.ru>)
List pgsql-hackers
Tree view
On Thu, Aug 4, 2016 at 2:28 PM, Ildar Musin <i.musin@postgrespro.ru> wrote:
I was looking through the buffer manager's code and have noticed that function PinBuffer has an unused 'strategy' argument. It's seems that after refactoring made by Alexander Korotkov and Andres Freund (48354581a49c30f5757c203415aa8412d85b0f70) it became useless. The attached patch removes it. Probably someone more advanced could edit the function description to reflect changes?

48354581 contain unintentional change that made 'strategy' argument of PinBuffer unused.
Since it was an unintentional change, it was decided to put old logic back.  See 9cf60332.
Thus, now 'strategy' argument of PinBuffer is used.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company 

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: logical replication launcher crash on buildfarm
Next
From: Jesper Pedersen
Date:
Subject: Re: [POC] A better way to expand hash indexes.