Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove unused function from walsender.c - Mailing list pgsql-hackers

From Simon Riggs
Subject Re: Remove unused function from walsender.c
Date
Msg-id CANP8+jLo1CRx=ChqumEPQuNUOSjo-inQdh-hQUFekEY4=M_YCA@mail.gmail.com
Whole thread Raw
In response to Remove unused function from walsender.c  (Fujii Masao <masao.fujii@gmail.com>)
Responses Re: Remove unused function from walsender.c  (Fujii Masao <masao.fujii@gmail.com>)
List pgsql-hackers
Tree view
On 11 April 2016 at 08:05, Fujii Masao <masao.fujii@gmail.com> wrote:
 
There is an unused function GetOldestWALSendPointer() in walsender.c.
Per comment, it was introduced because we may need it in the future for
synchronous replication.

Now we have very similar function SyncRepGetOldestSyncRecPtr() in
syncrep.c. Which makes me think that GetOldestWALSendPointer()
no longer needs to be maintained. So, is it time to remove that unused
function?

Seems sensible cleanup to me.

--
Simon Riggs                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

pgsql-hackers by date:

Previous
From: Simon Riggs
Date:
Subject: Re: Removing the TRACE_SORT macro
Next
From: Andres Freund
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics