Re: Remove unused function from walsender.c - Mailing list pgsql-hackers

From Fujii Masao
Subject Re: Remove unused function from walsender.c
Date
Msg-id CAHGQGwHuv3TqZu=72CQANW6v-b-1d1cx_tXBG9g3J-oPJWOH5Q@mail.gmail.com
Whole thread Raw
In response to Re: Remove unused function from walsender.c  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
On Tue, Apr 12, 2016 at 6:36 AM, Simon Riggs <simon@2ndquadrant.com> wrote:
> On 11 April 2016 at 08:05, Fujii Masao <masao.fujii@gmail.com> wrote:
>
>>
>> There is an unused function GetOldestWALSendPointer() in walsender.c.
>> Per comment, it was introduced because we may need it in the future for
>> synchronous replication.
>>
>> Now we have very similar function SyncRepGetOldestSyncRecPtr() in
>> syncrep.c. Which makes me think that GetOldestWALSendPointer()
>> no longer needs to be maintained. So, is it time to remove that unused
>> function?
>
>
> Seems sensible cleanup to me.

Yep, pushed the cleanup patch.

Regards,

-- 
Fujii Masao



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Re: [COMMITTERS] pgsql: Avoid extra locks in GetSnapshotData if old_snapshot_threshold <
Next
From: Fujii Masao
Date:
Subject: Re: Support for N synchronous standby servers - take 2