Re: pg_receivewal: remove extra conn = NULL; in StreamLog - Mailing list pgsql-hackers

From Bharath Rupireddy
Subject Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Date
Msg-id CALj2ACVWVb-W1gV9mvLRpENGdJ1rX7RrKBc81hLMfN_ooYqPFw@mail.gmail.com
Whole thread Raw
In response to Re: pg_receivewal: remove extra conn = NULL; in StreamLog  (Daniel Gustafsson <daniel@yesql.se>)
Responses Re: pg_receivewal: remove extra conn = NULL; in StreamLog  (Daniel Gustafsson <daniel@yesql.se>)
List pgsql-hackers
On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>
> > It seems there's a redundant assignment statement conn = NULL in
> > pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> > Thoughts?
>
> Agreed, while harmless this is superfluous since conn is already set to NULL
> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
> Unless there are objections I’ll apply this tomorrow or Monday.

Thanks for picking this up. I added this to CF to not lose it in the
wild - https://commitfest.postgresql.org/34/3317/

Regards,
Bharath Rupireddy.



pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Kerberos delegation support in libpq and postgres_fdw
Next
From: "REIX, Tony"
Date:
Subject: RE: AIX: Symbols are missing in libpq.a