Postgres Pro
Downloads
Home   >   mailing lists

Re: pg_receivewal: remove extra conn = NULL; in StreamLog - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Date
Msg-id 0C844850-3F65-4558-B3CB-8D0C29C387B9@yesql.se
Whole thread Raw
In response to pg_receivewal: remove extra conn = NULL; in StreamLog  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
Responses Re: pg_receivewal: remove extra conn = NULL; in StreamLog  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
Tree view 
> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:

> It seems there's a redundant assignment statement conn = NULL in
> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
> Thoughts?

Agreed, while harmless this is superfluous since conn is already set to NULL
after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
Unless there are objections I’ll apply this tomorrow or Monday.

--
Daniel Gustafsson        https://vmware.com/

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: extended stats objects are the only thing written like "%s"."%s"
Next
From: Álvaro Herrera
Date:
Subject: Re: Autovacuum on partitioned table (autoanalyze)