Re: pg_receivewal: remove extra conn = NULL; in StreamLog - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: pg_receivewal: remove extra conn = NULL; in StreamLog
Date
Msg-id 7D5281B9-39E6-4450-9460-BC26BD739F41@yesql.se
Whole thread Raw
In response to Re: pg_receivewal: remove extra conn = NULL; in StreamLog  (Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>)
List pgsql-hackers
> On 1 Sep 2021, at 10:58, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>
> On Sun, Aug 29, 2021 at 1:27 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 28 Aug 2021, at 14:10, Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com> wrote:
>>
>>> It seems there's a redundant assignment statement conn = NULL in
>>> pg_receivewal's StreamLog function. Attaching a tiny patch herewith.
>>> Thoughts?
>>
>> Agreed, while harmless this is superfluous since conn is already set to NULL
>> after the PQfinish call a few lines up (which was added in a4205fa00d526c3).
>> Unless there are objections I’ll apply this tomorrow or Monday.
>
> Thanks for picking this up. I added this to CF to not lose it in the
> wild - https://commitfest.postgresql.org/34/3317/

Pushed to master, and entry closed. Thanks.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Daniel Gustafsson
Date:
Subject: Re: Online verification of checksums
Next
From: Ajin Cherian
Date:
Subject: Re: [BUG]Update Toast data failure in logical replication